These changes make this function more testable and prepares it for
reconciling pollable contenders without re-calling getPollableContenders
unnecessarily.
Inspired by this feedback: https://reviews.bitcoinabc.org/D17607#inline-77172
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project
ninja check-avalanche
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- sc-status-local-test
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 32387 Build 64263: Build Diff lint-circular-dependencies · build-debug · build-clang · build-clang-tidy · build-without-wallet · build-diff Build 64262: arc lint + arc unit
Event Timeline
| src/avalanche/processor.cpp | ||
|---|---|---|
| 926 | You should create another version that takes only pindex to avoid this pattern: bool Processor::setContenderStatusForLocalWinners(const CBlockIndex *pindex) {
std::vector<StakeContenderId> dummy;
return setContenderStatusForLocalWinners(pindex, dummy);
} | |