These changes make this function more testable and prepares it for
reconciling pollable contenders without re-calling getPollableContenders
unnecessarily.
Inspired by this feedback: https://reviews.bitcoinabc.org/D17607#inline-77172
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC2c29ef6261c7: [avalanche] Improve API for setContenderStatusForLocalWinners
ninja check-avalanche
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- sc-status-local-test
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 32394 Build 64277: Build Diff build-without-wallet · build-debug · build-diff · build-clang · build-clang-tidy · lint-circular-dependencies Build 64276: arc lint + arc unit
Event Timeline
| src/avalanche/processor.cpp | ||
|---|---|---|
| 926 ↗ | (On Diff #52626) | You should create another version that takes only pindex to avoid this pattern: bool Processor::setContenderStatusForLocalWinners(const CBlockIndex *pindex) {
std::vector<StakeContenderId> dummy;
return setContenderStatusForLocalWinners(pindex, dummy);
} |
| src/avalanche/processor.cpp | ||
|---|---|---|
| 926 ↗ | (On Diff #52626) | I will do this, but I strongly suspect it will be cleaned up in the near future. pollableContenders is supposed to be utilized for polling which is a WIP |