Differential D17699

[avalanche] Clarify and simplify checking polled contenders
ClosedPublic
Actions

Authored by roqqit on Tue, Feb 25, 20:09.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC251c3b16b672: [avalanche] Clarify and simplify checking polled contenders

Summary

The current implementation is unnecessarily verbose and spreads out the accounting, making the intent less clear.

This patch makes it more clear and concise.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sc-get-polled-cids

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32483
Build 64454: Build Diff	build-debug · build-diff · build-without-wallet · build-clang-tidy · build-clang
Build 64453: arc lint + arc unit

Event Timeline

roqqit created this revision.Tue, Feb 25, 20:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Feb 25, 20:09

roqqit requested review of this revision.Tue, Feb 25, 20:09

Fabien accepted this revision.Tue, Feb 25, 20:16

This revision is now accepted and ready to land.Tue, Feb 25, 20:16

Harbormaster completed remote builds in B32483: Diff 52762.Tue, Feb 25, 20:19

Closed by commit rABC251c3b16b672: [avalanche] Clarify and simplify checking polled contenders (authored by roqqit). · Explain WhyTue, Feb 25, 20:23

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC251c3b16b672: [avalanche] Clarify and simplify checking polled contenders.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_contender_voting.py

40 lines

Diff 52762

View Options

test/functional/abc_p2p_avalanche_contender_voting.py

[avalanche] Clarify and simplify checking polled contendersClosedPublicActions