[avalanche] Simplify contenders by treating rejection and invalidation the same
Needs RevisionPublic
Actions

Authored by roqqit on Wed, Feb 26, 22:34.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

This provides a stronger guarantee that once a contender is finalized, it will never be reverted, even if the system managed to re-poll a finalized contender. We don't really care that invalidated contenders do not get removed from the winner set so long as blocks get mined with staking rewards going to a finalized contender.

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sc-rm-invalidate

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32505
Build 64498: Build Diff	build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-clang · build-debug · build-diff
Build 64497: arc lint + arc unit

Event Timeline

roqqit created this revision.Wed, Feb 26, 22:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Feb 26, 22:34

roqqit requested review of this revision.Wed, Feb 26, 22:34

Harbormaster completed remote builds in B32505: Diff 52789.Wed, Feb 26, 22:45

Fabien requested changes to this revision.Thu, Feb 27, 08:19

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/test/stakecontendercache_tests.cpp
249	This one should still be valid, just use reject instead of invalidate
262	It's worth testing the actual behavior, aka rejecting does not undo finalization