Differential D17710

[avalanche] Simplify contenders by treating rejection and invalidation the same
ClosedPublic
Actions

Authored by roqqit on Feb 26 2025, 22:34.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCdc136cfed9c4: [avalanche] Simplify contenders by treating rejection and invalidation the same

Summary

This provides a stronger guarantee that once a contender is finalized, it will never be reverted, even if the system managed to re-poll a finalized contender. We don't really care that invalidated contenders do not get removed from the winner set so long as blocks get mined with staking rewards going to a finalized contender.

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sc-rm-invalidate

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32525
Build 64538: Build Diff	build-without-wallet · build-debug · build-clang-tidy · build-clang · lint-circular-dependencies · build-diff
Build 64537: arc lint + arc unit

Event Timeline

roqqit created this revision.Feb 26 2025, 22:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2025, 22:34

roqqit requested review of this revision.Feb 26 2025, 22:34

Harbormaster completed remote builds in B32505: Diff 52789.Feb 26 2025, 22:45

Fabien requested changes to this revision.Feb 27 2025, 08:19

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/test/stakecontendercache_tests.cpp
249 ↗	(On Diff #52789)	This one should still be valid, just use reject instead of invalidate
262 ↗	(On Diff #52789)	It's worth testing the actual behavior, aka rejecting does not undo finalization

This revision now requires changes to proceed.Feb 27 2025, 08:19

roqqit requested review of this revision.Feb 27 2025, 18:29

roqqit added inline comments.

src/avalanche/test/stakecontendercache_tests.cpp
249 ↗	(On Diff #52789)	This is already handled by the reject case above since each proof has a different state.
262 ↗	(On Diff #52789)	This is already handled by the reject case above since each proof has a different state.