Differential D17766

[e.cash] Added localeCash to "use-ecash" page
ClosedPublic
Actions

Authored by Kronkmeister on Fri, Mar 7, 15:08.

Details

Reviewers

Mengerian

Group Reviewers

Restricted Project

Commits

rABC01eb54fab9a2: [e.cash] Added localeCash to "use-ecash" page

Summary

Added localeCash service to use-ecash, uploaded localeCash.png image and fixed case naming issue
of localecash.png file

Test Plan

visit e.cash/use-ecash and see if everything works correctly

Diff Detail

Repository

rABC Bitcoin ABC

Branch

localecash

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32625
Build 64738: Build Diff
Build 64737: arc lint + arc unit

Event Timeline

Kronkmeister created this revision.Fri, Mar 7, 15:08

Harbormaster completed remote builds in B32624: Diff 52968.Fri, Mar 7, 15:08

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41370 for the next 60 minutes.

First diff draft had an issue with the upper case C of localeCash.png which I uploaded. It worked on my end but doesn't work here on phab. I made a commit to fix that issue and squashed it into one commit here. Not sure if it is reflected but just wanted to note it here. But the diff seems to work out as intended now.

Kronkmeister published this revision for review.Fri, Mar 7, 15:25

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41999 for the next 60 minutes.

Mengerian added inline comments.Fri, Mar 7, 17:40