Page MenuHomePhabricator
Differential D17783

[chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client
ClosedPublic
Actions

Authored by hazzarust on Wed, Mar 12, 12:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC18cf3e52f32d: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite…
Summary

Tests verify transaction and block retrieval from the Chronik client. They check:

  • Block and transaction retrieval by height and hash
  • Transaction validation in mempool and after mining
  • Raw transaction data verification
  • Pagination of block transactions with custom page sizes
  • Error handling for non-existent or invalidated blocks/transactions
  • Proper handling of coinbase transactions

This ensures the Chronik client correctly handles transaction queries and blockchain state changes.

Test Plan

Please set BUILD_DIR env to export BUILD_DIR="/path/to/build_dir
UNIX: ./contrib/teamcity/build-configurations.py build-bitcoinsuite-chronik-client

Diff Detail

Repository
rABC Bitcoin ABC
Branch
blocktxs
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixmodules/bitcoinsuite-chronik-client/tests/blocktxs_and_tx_and_rawtx.rs:438WHITESPACE1Found trailing whitespace(s).
Unit
No Test Coverage
Build Status
Buildable 32709
Build 64906: Build Diffbuild-bitcoinsuite-chronik-client
Build 64905: arc lint + arc unit

Event Timeline

hazzarust requested review of this revision.Wed, Mar 12, 12:03
hazzarust created this revision.
hazzarust edited the summary of this revision. (Show Details)Wed, Mar 12, 12:07
hazzarust edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B32678: Diff 53041.Wed, Mar 12, 12:12
Fabien requested changes to this revision.Wed, Mar 12, 13:39
Fabien added a subscriber: Fabien.
Fabien added inline comments.
modules/bitcoinsuite-chronik-client/tests/blocktxs_and_tx_and_rawtx.rs
221 ↗(On Diff #53041)

Please avoid the boilerplate and make it its own function

This revision now requires changes to proceed.Wed, Mar 12, 13:39
hazzarust updated this revision to Diff 53087.Thu, Mar 13, 15:04

Removed boilerplate and replaced with assert_status_code_eq!()

hazzarust updated this revision to Diff 53089.Thu, Mar 13, 15:08

lint

hazzarust added a comment.EditedThu, Mar 13, 15:08

Still need to add comprehensive comments to explain whats going on within the code, very similar to the TS code - will do this later this evening.

Fabien requested changes to this revision.Thu, Mar 13, 15:27
Fabien added inline comments.
modules/bitcoinsuite-chronik-client/tests/blocktxs_and_tx_and_rawtx.rs
344 ↗(On Diff #53089)

In general don't put comments on the same line as your code. Doing that means that updating the comment changes the line with the code, making it non obvious it's just a comment change. Just move it all on the above line

472 ↗(On Diff #53089)

?

This revision now requires changes to proceed.Thu, Mar 13, 15:27
Harbormaster completed remote builds in B32711: Diff 53089.Thu, Mar 13, 15:37
Harbormaster completed remote builds in B32709: Diff 53087.Thu, Mar 13, 15:54
hazzarust updated this revision to Diff 53096.Thu, Mar 13, 19:30

Added comments from TS implementation into this implementation

Harbormaster completed remote builds in B32716: Diff 53096.Thu, Mar 13, 19:36
hazzarust updated this revision to Diff 53109.Fri, Mar 14, 13:05

Remove useless comments

hazzarust updated this revision to Diff 53110.Fri, Mar 14, 13:06

lint

Harbormaster completed remote builds in B32726: Diff 53109.Fri, Mar 14, 13:11
Harbormaster completed remote builds in B32727: Diff 53110.Fri, Mar 14, 13:16
Fabien accepted this revision.Fri, Mar 14, 20:36
This revision is now accepted and ready to land.Fri, Mar 14, 20:36
Closed by commit rABC18cf3e52f32d: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite… (authored by hazzarust). · Explain WhySat, Mar 15, 17:24
This revision was automatically updated to reflect the committed changes.
hazzarust added a commit: rABC18cf3e52f32d: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite….

Revision Contents
Changeset List

PathSize
modules/
bitcoinsuite-chronik-client/
tests/
501 lines

Diff 53087

View Options

modules/bitcoinsuite-chronik-client/tests/blocktxs_and_tx_and_rawtx.rs

Loading...