Proposed ui edit to make the avalanche finalized indicator a bit more subtle.
Its good info for sure, but not critical to most users and I was finding the blue check mark/spinner was taking up some prime space and attention.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC0113f0b821a3: [cashtab] Move finalized indicator
npm start and try sending a transaction, observe finilizing state, and check the check mark
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cashtab-move-finalized-indicator
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 33095 Build 65674: Build Diff cashtab-tests Build 65673: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
[36m<svg[39m
[33mtitle[39m=[32m"copy-paste"[39m
[36m/>[39m
[36m</button>[39m
[36m</div>[39m
[36m<a[39m
[33mclass[39m=[32m"sc-chPdSV fCIcLj"[39m
[33mhref[39m=[32m"https://explorer.e.cash/tx/ac83faac54059c89c41dea4c3d6704e4f74fb82e4ad2fb948e640f1d19b760de"[39m
[33mrel[39m=[32m"noreferrer"[39m
[33mtarget[39m=[32m"_blank"[39m
[36m>[39m
[36m<svg[39m
[33mclass[39m=[32m"sc-brqgnP itPjSE"[39m
[36m/>[39m
[36m</a>[39m
[36m<a[39m
[33mclass[39m=[32m"sc-chPdSV fCIcLj"[39m
[33mhref[39m=[32m"https://blockchair.com/ecash/transaction/ac83faac54059c89c41dea4c3d6704e4f74fb82e4ad2fb948e640f1d19b760de.pdf"[39m
[33mrel[39m=[32m"noreferrer"[39m
[33mtarget[39m=[32m"_blank"[39m
[36m>[39m
[36m<svg[39m
[33mclass[39m=[32m"sc-cMljjf cdzzdJ"[39m
[36m/>[39m
[36m</a>[39m
[36m<button[39m
[33mclass[39m=[32m"sc-kAzzGY jjfqUh"[39m
[36m>[39m
[36m<svg[39m
[33mtitle[39m=[32m"add-contact"[39m
[36m/>[39m
[36m</button>[39m
[36m</div>[39m
[36m</div>[39m
[36m</div>[39m
[36m</div>[39m
[36m</body>[39m
[0m [90m 114 |[39m
[90m 115 |[39m [90m// We see the avalanche finalized check[39m
[31m[1m>[22m[39m[90m 116 |[39m expect(screen[33m.[39mgetByTitle([32m'Finalized by Avalanche'[39m))[33m.[39mtoBeInTheDocument()[33m;[39m
[90m |[39m [31m[1m^[22m[39m
[90m 117 |[39m
[90m 118 |[39m [90m// If we expand the panel, we see the exact XEC amount[39m
[90m 119 |[39m [90m// Expand the panel[39m[0m
at Object.getElementError (node_modules/@testing-library/dom/dist/config.js:37:19)
at getElementError (node_modules/@testing-library/dom/dist/query-helpers.js:20:35)
at getMultipleElementsFoundError (node_modules/@testing-library/dom/dist/query-helpers.js:23:10)
at node_modules/@testing-library/dom/dist/query-helpers.js:55:13
at node_modules/@testing-library/dom/dist/query-helpers.js:95:19
at Object.getByTitle (src/components/Home/Tx/__tests__/index.test.js:116:23)
Test Suites: 1 failed, 39 passed, 40 total
Tests: 1 failed, 1184 passed, 1185 total
Snapshots: 0 total
Time: 54.739 s
mv: cannot move 'test' to '/work/abc-ci-builds/cashtab-tests/test': Directory not empty
Build cashtab-tests failed with exit code 1Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
index.ts | 100 | 100 | 100 | 100 |
src/token-protocols/slpv1/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
src/transactions | 98.79 | 92.3 | 100 | 98.79 |
index.js | 98.79 | 92.3 | 100 | 98.79 | 182
src/transactions/fixtures | 100 | 100 | 100 | 100 |
mocks.ts | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
src/validation | 96.57 | 94.42 | 100 | 96.79 |
index.ts | 96.57 | 94.42 | 100 | 96.79 | 70-71,236,271,337,535,642-643,934,939,1318-1321
src/validation/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
src/wallet | 94.18 | 88.34 | 92.72 | 94.15 |
context.tsx | 100 | 100 | 100 | 100 |
index.ts | 100 | 100 | 100 | 100 |
useWallet.ts | 90.54 | 79.68 | 85.71 | 90.54 | 127,209-210,587-593,632,637,694-695,706,711-727,741,767,804,819,832-834,893,930,1003
src/wallet/fixtures | 100 | 100 | 100 | 100 |
mocks.js | 100 | 100 | 100 | 100 |
vectors.js | 100 | 100 | 100 | 100 |
----------------------------------------|---------|----------|---------|---------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='5549']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='6407']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='3191']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='3870']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='1023']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='1252']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='5448']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='6293']
##teamcity[blockClosed name='Code Coverage Summary']
Summary of all failing tests
FAIL src/components/Etokens/__tests__/TokenActions.test.js (48.649 s)
● <Token /> available actions rendered › We can send an SLP1 NFT
expect(element).toBeChecked()
Received element is not checked:
<input class="sc-jzgbtB jgfSAg" id="Toggle Sell NFT" name="Toggle Sell NFT" title="Toggle Sell NFT" type="checkbox" />
[0m [90m 1028 |[39m [90m// On load, default action for NFT is to list it[39m
[90m 1029 |[39m [36mconst[39m sellActionSwitch [33m=[39m screen[33m.[39mgetByTitle([32m'Toggle Sell NFT'[39m)[33m;[39m
[31m[1m>[22m[39m[90m 1030 |[39m expect(sellActionSwitch)[33m.[39mtoBeChecked()[33m;[39m
[90m |[39m [31m[1m^[22m[39m
[90m 1031 |[39m
[90m 1032 |[39m [90m// Sending is disabled[39m
[90m 1033 |[39m [36mconst[39m sendActionSwitch [33m=[39m screen[33m.[39mgetByTitle([32m'Toggle Send'[39m)[33m;[39m[0m
at Object.toBeChecked (src/components/Etokens/__tests__/TokenActions.test.js:1030:34)
Test Suites: 1 failed, 39 passed, 40 total
Tests: 1 failed, 1184 passed, 1185 total
Snapshots: 0 total
Time: 54.669 s
mv: cannot move 'test' to '/work/abc-ci-builds/cashtab-tests/test': Directory not empty
Build cashtab-tests failed with exit code 1Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
mocks.js | 100 | 100 | 100 | 100 | vectors.js | 0 | 0 | 0 | 0 | src/opreturn | 97.6 | 96.25 | 100 | 97.6 | index.ts | 97.6 | 96.25 | 100 | 97.6 | 149,165-166 src/opreturn/fixtures | 100 | 100 | 100 | 100 | vectors.js | 100 | 100 | 100 | 100 | src/test | 92.5 | 66.66 | 100 | 92.5 | index.tsx | 92.5 | 66.66 | 100 | 92.5 | 119,146-147 src/token-protocols | 95.55 | 90.9 | 100 | 95.55 | index.ts | 95.55 | 90.9 | 100 | 95.55 | 161,182 src/token-protocols/alp | 100 | 93.33 | 100 | 100 | index.ts | 100 | 93.33 | 100 | 100 | 68 src/token-protocols/alp/fixtures | 100 | 100 | 100 | 100 | mocks.ts | 100 | 100 | 100 | 100 | vectors.ts | 100 | 100 | 100 | 100 | src/token-protocols/fixtures | 100 | 100 | 100 | 100 | vectors.ts | 100 | 100 | 100 | 100 | src/token-protocols/slpv1 | 100 | 100 | 100 | 100 | index.ts | 100 | 100 | 100 | 100 | src/token-protocols/slpv1/fixtures | 100 | 100 | 100 | 100 | mocks.js | 100 | 100 | 100 | 100 | vectors.js | 100 | 100 | 100 | 100 | src/transactions | 98.79 | 92.3 | 100 | 98.79 | index.js | 98.79 | 92.3 | 100 | 98.79 | 182 src/transactions/fixtures | 100 | 100 | 100 | 100 | mocks.ts | 100 | 100 | 100 | 100 | vectors.js | 100 | 100 | 100 | 100 | src/validation | 96.57 | 94.42 | 100 | 96.79 | index.ts | 96.57 | 94.42 | 100 | 96.79 | 70-71,236,271,337,535,642-643,934,939,1318-1321 src/validation/fixtures | 100 | 100 | 100 | 100 | mocks.js | 100 | 100 | 100 | 100 | vectors.js | 100 | 100 | 100 | 100 | src/wallet | 94.18 | 88.34 | 92.72 | 94.15 | context.tsx | 100 | 100 | 100 | 100 | index.ts | 100 | 100 | 100 | 100 | useWallet.ts | 90.54 | 79.68 | 85.71 | 90.54 | 127,209-210,587-593,632,637,694-695,706,711-727,741,767,804,819,832-834,893,930,1003 src/wallet/fixtures | 100 | 100 | 100 | 100 | mocks.js | 100 | 100 | 100 | 100 | vectors.js | 100 | 100 | 100 | 100 | ----------------------------------------|---------|----------|---------|---------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- ##teamcity[blockOpened name='Code Coverage Summary'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='5549'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='6407'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='3195'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='3870'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='1023'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='1252'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='5448'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='6293'] ##teamcity[blockClosed name='Code Coverage Summary'] Test Suites: 40 passed, 40 total Tests: 1185 passed, 1185 total Snapshots: 0 total Time: 48.277 s /work/cashtab/coverage/lcov-report /work/cashtab /work/abc-ci-builds/cashtab-tests /work/cashtab /work/abc-ci-builds/cashtab-tests mv: cannot move 'test' to '/work/abc-ci-builds/cashtab-tests/test': Directory not empty Build cashtab-tests failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
mocks.js | 100 | 100 | 100 | 100 | vectors.js | 0 | 0 | 0 | 0 | src/opreturn | 97.6 | 96.25 | 100 | 97.6 | index.ts | 97.6 | 96.25 | 100 | 97.6 | 149,165-166 src/opreturn/fixtures | 100 | 100 | 100 | 100 | vectors.js | 100 | 100 | 100 | 100 | src/test | 92.5 | 66.66 | 100 | 92.5 | index.tsx | 92.5 | 66.66 | 100 | 92.5 | 119,146-147 src/token-protocols | 95.55 | 90.9 | 100 | 95.55 | index.ts | 95.55 | 90.9 | 100 | 95.55 | 161,182 src/token-protocols/alp | 100 | 93.33 | 100 | 100 | index.ts | 100 | 93.33 | 100 | 100 | 68 src/token-protocols/alp/fixtures | 100 | 100 | 100 | 100 | mocks.ts | 100 | 100 | 100 | 100 | vectors.ts | 100 | 100 | 100 | 100 | src/token-protocols/fixtures | 100 | 100 | 100 | 100 | vectors.ts | 100 | 100 | 100 | 100 | src/token-protocols/slpv1 | 100 | 100 | 100 | 100 | index.ts | 100 | 100 | 100 | 100 | src/token-protocols/slpv1/fixtures | 100 | 100 | 100 | 100 | mocks.js | 100 | 100 | 100 | 100 | vectors.js | 100 | 100 | 100 | 100 | src/transactions | 98.79 | 92.3 | 100 | 98.79 | index.js | 98.79 | 92.3 | 100 | 98.79 | 182 src/transactions/fixtures | 100 | 100 | 100 | 100 | mocks.ts | 100 | 100 | 100 | 100 | vectors.js | 100 | 100 | 100 | 100 | src/validation | 96.57 | 94.42 | 100 | 96.79 | index.ts | 96.57 | 94.42 | 100 | 96.79 | 70-71,236,271,337,535,642-643,934,939,1318-1321 src/validation/fixtures | 100 | 100 | 100 | 100 | mocks.js | 100 | 100 | 100 | 100 | vectors.js | 100 | 100 | 100 | 100 | src/wallet | 94.18 | 88.34 | 92.72 | 94.15 | context.tsx | 100 | 100 | 100 | 100 | index.ts | 100 | 100 | 100 | 100 | useWallet.ts | 90.54 | 79.68 | 85.71 | 90.54 | 127,209-210,587-593,632,637,694-695,706,711-727,741,767,804,819,832-834,893,930,1003 src/wallet/fixtures | 100 | 100 | 100 | 100 | mocks.js | 100 | 100 | 100 | 100 | vectors.js | 100 | 100 | 100 | 100 | ----------------------------------------|---------|----------|---------|---------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- ##teamcity[blockOpened name='Code Coverage Summary'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='5548'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='6407'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='3196'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='3870'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='1023'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='1252'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='5447'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='6293'] ##teamcity[blockClosed name='Code Coverage Summary'] Test Suites: 40 passed, 40 total Tests: 1185 passed, 1185 total Snapshots: 0 total Time: 49.457 s /work/cashtab/coverage/lcov-report /work/cashtab /work/abc-ci-builds/cashtab-tests /work/cashtab /work/abc-ci-builds/cashtab-tests mv: cannot move 'test' to '/work/abc-ci-builds/cashtab-tests/test': Directory not empty Build cashtab-tests failed with exit code 1
Comment Actions
rebase and wait for CI to clear but looks good
FYI deployed to https://cashtab-local-dev.netlify.app/ for testing