The original log is very helpful for debugging functional tests, however we are left guessing what proofids are associated with contenders that were not promoted. This diff reuses that log and clearly indicates whether or not it was promoted.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABC5d39d807f0a9: [avalanche] Also log when contenders are not promoted
./test/functional/test_runner.py --nocleanup abc_p2p_avalanche_contender_voting
Inspect the log and see "was NOT promoted" log messages intermixed with "was promoted".
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- sc-better-promote-logs
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 33142 Build 65767: Build Diff lint-circular-dependencies · build-debug · build-clang · build-clang-tidy · build-without-wallet · build-diff Build 65766: arc lint + arc unit