Page MenuHomePhabricator

[e.cash] init v2 build
Needs ReviewPublic

Authored by johnkuney on Wed, May 14, 21:13.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Looking to start on the new design for e.cash. Since it is an entirely new build with basically no shared design elements
I'm proposing a fresh project with the latest next.js and tailwinds for styles

Test Plan

npm i and npm run dev to see the site runs with basic e.cash setup

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-new-build
Lint
Lint Errors
SeverityLocationCodeMessage
Errorweb/e.cash_v2/README.md:PRETTIERLinter error
Errorweb/e.cash_v2/app/globals.css:PRETTIERLinter error
Errorweb/e.cash_v2/app/layout.tsx:PRETTIERLinter error
Errorweb/e.cash_v2/app/layout.tsx:1ESLINTheader/header
Errorweb/e.cash_v2/app/page.tsx:PRETTIERLinter error
Errorweb/e.cash_v2/app/page.tsx:1ESLINTheader/header
Errorweb/e.cash_v2/next.config.ts:PRETTIERLinter error
Errorweb/e.cash_v2/next.config.ts:1ESLINTheader/header
Errorweb/e.cash_v2/package-lock.json:PRETTIERLinter error
Errorweb/e.cash_v2/package.json:PRETTIERLinter error
Errorweb/e.cash_v2/postcss.config.mjs:1ESLINTheader/header
Errorweb/e.cash_v2/tsconfig.json:PRETTIERLinter error
Unit
No Test Coverage
Build Status
Buildable 33306
Build 66094: Build Diff
Build 66093: arc lint + arc unit

Event Timeline

fix lint errors, add prettier tailwinds to root

bytesofman added a subscriber: bytesofman.

see contrib/team-city/build-configurations.yml and add a preview-e.cash-v2 modeled after the existing preview-e.cash

we can handle prod CI separately / later but we should set up previews immediately to support the review process

web/e.cash_v2/public/favicon.png
1 โ†—(On Diff #53995)

do we plan on this to be the same?

This revision now requires changes to proceed.Thu, May 15, 12:39

okay cool, I'll add that

web/e.cash_v2/public/favicon.png
1 โ†—(On Diff #53995)

well not necessarily. I haven't seen if we have a new one yet, but figured get it setup now and can replace it easy when we have the new one

I love it, Next.js and Tailwind is my favorite combination. Especially the latest version of Tailwind. If there are any design and dev needs, please ping me.

Tail of the build log:

#1 [internal] load build definition from Dockerfile
#1 sha256:db4f287c33aad300f8c8eb75dfa6170742a2b6658b4719f889f9036e01c92a61
#1 transferring dockerfile: 2B done
#1 DONE 0.1s

#2 [internal] load .dockerignore
#2 sha256:39bbbd2d134bd388a490e2f9aefab1dfee0b27843a982012b1a17ae48c1f4328
#2 transferring context: 2B done
#2 DONE 0.1s
failed to solve with frontend dockerfile.v0: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount646349231/Dockerfile: no such file or directory
Build preview-e.cash_v2 failed with exit code 1