[cashtab] Fix header copy address button hover styles
ClosedPublic
Actions

Authored by johnkuney on Mon, May 19, 06:37.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCe519af1dbe60: [cashtab] Fix header copy address button hover styles

Summary

Reported that the copy address button in the header, on mobile, would hang on the hover state background color
Moving the hover styles to a more specific selector

Test Plan

preview the site and check out the button on mobile

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cashtab-copy-icon-mobile

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33356
Build 66193: Build Diff	cashtab-tests
Build 66192: arc lint + arc unit

Event Timeline

johnkuney created this revision.Mon, May 19, 06:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, May 19, 06:37

johnkuney requested review of this revision.Mon, May 19, 06:37

Harbormaster completed remote builds in B33356: Diff 54061.Mon, May 19, 06:42

seems like the root cause here is that mobile browsers occasionally do not clear the hover state. In testing, noticed this is also happening with the SvgButtonOrLinkCss components (e.g. the copy paste button on the wallet page)

various solutions but the one here does seem to be the most concise.

Please also apply on the SvgButtonOrLinkCss component while we're at it (i've done this and applied + deployed at cashtab.io, works).

This revision is now accepted and ready to land.Mon, May 19, 12:42

add change to SvgButtonOrLinkCss as well

Harbormaster completed remote builds in B33372: Diff 54083.Mon, May 19, 13:29

Closed by commit rABCe519af1dbe60: [cashtab] Fix header copy address button hover styles (authored by johnkuney). · Explain WhyMon, May 19, 13:32

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABCe519af1dbe60: [cashtab] Fix header copy address button hover styles.