Page MenuHomePhabricator
Files F14864837

D2009.id5667.diff
No OneTemporary
Actions

D2009.id5667.diff
View Options

diff --git a/test/functional/signrawtransactions.py b/test/functional/signrawtransactions.py
--- a/test/functional/signrawtransactions.py
+++ b/test/functional/signrawtransactions.py
@@ -12,6 +12,7 @@
def set_test_params(self):
self.setup_clean_chain = True
self.num_nodes = 1
+ self.extra_args = [["-deprecatedrpc=signrawtransaction"]]
def successful_signing_test(self):
"""Creates and signs a valid raw transaction with one input.
@@ -40,12 +41,16 @@
rawTx, privKeys, inputs)
# 1) The transaction has a complete set of signatures
- assert 'complete' in rawTxSigned
- assert_equal(rawTxSigned['complete'], True)
+ assert rawTxSigned['complete']
# 2) No script verification error occurred
assert 'errors' not in rawTxSigned
+ # Perform the same test on signrawtransaction
+ rawTxSigned2 = self.nodes[0].signrawtransaction(
+ rawTx, inputs, privKeys)
+ assert_equal(rawTxSigned, rawTxSigned2)
+
def script_verification_error_test(self):
"""Creates and signs a raw transaction with valid (vin 0), invalid (vin 1) and one missing (vin 2) input script.
@@ -98,8 +103,7 @@
rawTx, privKeys, scripts)
# 3) The transaction has no complete set of signatures
- assert 'complete' in rawTxSigned
- assert_equal(rawTxSigned['complete'], False)
+ assert not rawTxSigned['complete']
# 4) Two script verification errors occurred
assert 'errors' in rawTxSigned
@@ -119,6 +123,11 @@
assert_equal(rawTxSigned['errors'][1]['txid'], inputs[2]['txid'])
assert_equal(rawTxSigned['errors'][1]['vout'], inputs[2]['vout'])
+ # Perform same test with signrawtransaction
+ rawTxSigned2 = self.nodes[0].signrawtransaction(
+ rawTx, scripts, privKeys)
+ assert_equal(rawTxSigned, rawTxSigned2)
+
def run_test(self):
self.successful_signing_test()
self.script_verification_error_test()

File Metadata

Mime Type
text/plain
Expires
Tue, May 20, 22:44 (4 h, 35 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5866086
Default Alt Text
D2009.id5667.diff (2 KB)

Event Timeline