Page MenuHomePhabricator

[Target v0.19] Deprecate and add test for signrawtransaction
Needs ReviewPublic

Authored by Fabien on Nov 6 2018, 13:23.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Summary

Deprecate signrawtransaction (target is v0.19).

Backport 3/3 of core PR10579 (part of commit d602348 + deprecation from 1e79c05)

Depends on D2008
Completes task T438

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D2009
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5118
Build 8299: Bitcoin ABC Teamcity Staging
Build 8298: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 6 2018, 13:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 6 2018, 13:23
jasonbcox accepted this revision.Nov 9 2018, 19:21
This revision is now accepted and ready to land.Nov 9 2018, 19:21
Fabien updated this revision to Diff 6266.Dec 3 2018, 17:51

Rebase

Fabien updated this revision to Diff 6312.Dec 9 2018, 20:45

Rebase

Fabien updated this revision to Diff 6316.Dec 9 2018, 21:05

Rebase

Fabien updated this revision to Diff 6323.Dec 10 2018, 16:04

Rebase

Fabien updated this revision to Diff 6527.Jan 6 2019, 12:12

Update to add signrawtransaction deprecation

Fabien requested review of this revision.Jan 6 2019, 12:14
Fabien retitled this revision from Add test for signrawtransaction to [Target v0.19] Deprecate abd add test for signrawtransaction.
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)
Fabien retitled this revision from [Target v0.19] Deprecate abd add test for signrawtransaction to [Target v0.19] Deprecate and add test for signrawtransaction.Jan 7 2019, 09:55
Fabien updated this revision to Diff 6537.Jan 7 2019, 09:58

Rebase

deadalnix requested changes to this revision.Jan 8 2019, 16:46
deadalnix added a subscriber: deadalnix.

Split deprecation from the backport of d60234885bcc07b1a7f85ded7731549ec2fcfefa

This revision now requires changes to proceed.Jan 8 2019, 16:47
Fabien updated this revision to Diff 6600.Jan 11 2019, 10:53

Only add deprecation

Fabien edited the summary of this revision. (Show Details)Jan 11 2019, 10:53
Fabien updated this revision to Diff 7296.Feb 11 2019, 12:47

Rebase

jasonbcox accepted this revision.Feb 12 2019, 23:47
deadalnix requested changes to this revision.Mon, Feb 25, 23:02

Can you rebase this ?

This revision now requires changes to proceed.Mon, Feb 25, 23:02
Fabien updated this revision to Diff 7518.Thu, Feb 28, 09:25

Rebase

deadalnix requested changes to this revision.Thu, Feb 28, 22:10
deadalnix added inline comments.
doc/release-notes.md
11 ↗(On Diff #7518)

Add a new lie at the end of file. You can see that These are specialized subsets of the signrawtransaction` RPC.` now appears as touched by this patch. We are not trying to save one byte.

This revision now requires changes to proceed.Thu, Feb 28, 22:10
Fabien updated this revision to Diff 7557.Fri, Mar 1, 13:43

Add a new line at the end of the release notes