Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc
ClosedPublic
Actions

Authored by Fabien on Apr 2 2019, 08:51.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGcffcc6a78558: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc
rABCcffcc6a78558: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc

Summary

This has been added before D2009 gets landed, it needs to be updated as
signrawtransaction is going to get deprecated in favor of
signrawtransactionwithwallet and signrawtransactionwithkey.

Test Plan

./test/functional/test_runner.py wallet_listsinceblock

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 2 2019, 08:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 2 2019, 08:51

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2009: [Target v0.19] Deprecate and add test for signrawtransaction.Apr 2 2019, 08:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5351: Diff 7898.Apr 2 2019, 09:07

jasonbcox accepted this revision.Apr 3 2019, 23:47

This revision is now accepted and ready to land.Apr 3 2019, 23:47

Closed by commit rABCcffcc6a78558: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc (authored by Fabien). · Explain WhyApr 4 2019, 12:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGINGcffcc6a78558: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc.Sep 18 2019, 22:52

Revision Contents
Changeset List

Path

Size

test/

functional/

wallet_listsinceblock.py

6 lines

Diff 7941

View Options

test/functional/wallet_listsinceblock.py

Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpcClosedPublicActions