Page MenuHomePhabricator
Differential D2009

[Target v0.19] Deprecate and add test for signrawtransaction
ClosedPublic
Actions

Authored by Fabien on Nov 6 2018, 13:23.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING92d66e964a47: [Target v0.19] Deprecate and add test for signrawtransaction
rABC92d66e964a47: [Target v0.19] Deprecate and add test for signrawtransaction
Summary

Deprecate signrawtransaction (target is v0.19).

Backport 3/3 of core PR10579 (part of commit d602348 + deprecation from 1e79c05)

Depends on D2763
Completes task T438

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10579_part3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4956
Build 7975: Bitcoin ABC Buildbot (legacy)
Build 7974: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Harbormaster completed remote builds in B4291: Diff 6312.Dec 9 2018, 20:55
Fabien updated this revision to Diff 6316.Dec 9 2018, 21:05

Rebase

teamcity added a comment.Dec 9 2018, 21:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 9 2018, 21:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4295: Diff 6316!Dec 9 2018, 21:14
teamcity added a comment.Dec 10 2018, 08:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 10 2018, 08:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Dec 10 2018, 15:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 10 2018, 15:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Fabien updated this revision to Diff 6323.Dec 10 2018, 16:04

Rebase

teamcity added a comment.Dec 10 2018, 16:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 10 2018, 16:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4299: Diff 6323.Dec 10 2018, 16:14
Fabien mentioned this in D2184: Prepare functional tests for deprecation of signrawtransaction rpc.Jan 4 2019, 18:14
Fabien updated this revision to Diff 6527.Jan 6 2019, 12:12

Update to add signrawtransaction deprecation

Fabien requested review of this revision.Jan 6 2019, 12:14
Fabien retitled this revision from Add test for signrawtransaction to [Target v0.19] Deprecate abd add test for signrawtransaction.
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)
teamcity added a comment.Jan 6 2019, 13:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 6 2019, 13:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4426: Diff 6527.Jan 6 2019, 13:49
Fabien retitled this revision from [Target v0.19] Deprecate abd add test for signrawtransaction to [Target v0.19] Deprecate and add test for signrawtransaction.Jan 7 2019, 09:55
Fabien updated this revision to Diff 6537.Jan 7 2019, 09:58

Rebase

teamcity added a comment.Jan 7 2019, 09:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 7 2019, 10:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4435: Diff 6537.Jan 7 2019, 10:07
deadalnix requested changes to this revision.Jan 8 2019, 16:46
deadalnix added a subscriber: deadalnix.

Split deprecation from the backport of d60234885bcc07b1a7f85ded7731549ec2fcfefa

This revision now requires changes to proceed.Jan 8 2019, 16:47
Fabien updated this revision to Diff 6600.Jan 11 2019, 10:53

Only add deprecation

Fabien edited the summary of this revision. (Show Details)Jan 11 2019, 10:53
teamcity added a comment.Jan 11 2019, 10:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 11 2019, 11:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4478: Diff 6600!Jan 11 2019, 11:04
teamcity added a comment.Jan 11 2019, 11:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 11 2019, 11:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4478: Diff 6600.Jan 11 2019, 11:26
Fabien updated this revision to Diff 7296.Feb 11 2019, 12:47

Rebase

teamcity added a comment.Feb 11 2019, 12:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 11 2019, 13:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4956: Diff 7296.Feb 11 2019, 13:01
Fabien mentioned this in D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.Feb 12 2019, 07:33
jasonbcox accepted this revision.Feb 12 2019, 23:47
deadalnix requested changes to this revision.Feb 25 2019, 23:02

Can you rebase this ?

This revision now requires changes to proceed.Feb 25 2019, 23:02
Fabien updated this revision to Diff 7518.Feb 28 2019, 09:25

Rebase

teamcity added a comment.Feb 28 2019, 09:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5103: Diff 7518.Feb 28 2019, 09:38
teamcity added a comment.Feb 28 2019, 09:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested changes to this revision.Feb 28 2019, 22:10
deadalnix added inline comments.
doc/release-notes.md
11 ↗(On Diff #7518)

Add a new lie at the end of file. You can see that These are specialized subsets of the signrawtransaction` RPC.` now appears as touched by this patch. We are not trying to save one byte.

This revision now requires changes to proceed.Feb 28 2019, 22:10
Fabien updated this revision to Diff 7557.Mar 1 2019, 13:43

Add a new line at the end of the release notes

teamcity added a comment.Mar 1 2019, 13:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5118: Diff 7557.Mar 1 2019, 13:56
teamcity added a comment.Mar 1 2019, 13:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Mar 25 2019, 17:44
deadalnix accepted this revision.Apr 1 2019, 23:39
This revision is now accepted and ready to land.Apr 1 2019, 23:39
Fabien mentioned this in D2763: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc.Apr 2 2019, 08:51
Fabien edited the summary of this revision. (Show Details)Apr 2 2019, 08:52
Fabien added a parent revision: D2763: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc.
Fabien removed a parent revision: D2008: Change signrawtransaction to signrawtransactionwithwallet in tests, add a test for legacy signrawtransaction.
Fabien updated this revision to Diff 7899.Apr 2 2019, 08:54

Rebase

teamcity added a comment.Apr 2 2019, 08:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5352: Diff 7899.Apr 2 2019, 09:08
teamcity added a comment.Apr 2 2019, 09:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien updated this revision to Diff 7918.Apr 2 2019, 19:29

Rebase

teamcity added a comment.Apr 2 2019, 19:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 2 2019, 19:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B5365: Diff 7918!Apr 2 2019, 19:40
jasonbcox accepted this revision.Apr 3 2019, 23:48
Fabien mentioned this in rABCcffcc6a78558: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc.Apr 4 2019, 12:37
Fabien updated this revision to Diff 7942.Apr 4 2019, 14:45

Rebase

teamcity added a comment.Apr 4 2019, 14:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 4 2019, 15:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5380: Diff 7942.Apr 4 2019, 15:01
Closed by commit rABC92d66e964a47: [Target v0.19] Deprecate and add test for signrawtransaction (authored by Fabien). · Explain WhyApr 4 2019, 15:15
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING92d66e964a47: [Target v0.19] Deprecate and add test for signrawtransaction.Sep 18 2019, 22:52
Fabien mentioned this in rSTAGINGcffcc6a78558: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc.

Revision Contents
Changeset List

PathSize
doc/
5 lines
src/
rpc/
14 lines
test/
functional/
1 line

Diff 7296

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

test/functional/rpc_signrawtransaction.py

Loading...