Page MenuHomePhabricator

hazzarust (Harry Grant)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2024, 14:52 (22 w, 6 d)
Slack Username
Harry

Recent Activity

Fri, Apr 25

hazzarust updated the diff for D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.

Roasted by linter, updating

Fri, Apr 25, 12:04
hazzarust updated the diff for D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.

Made changes

Fri, Apr 25, 11:27
hazzarust updated the diff for D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.

Added address.rs to chronik/bitcoinsuite-core, added documentation, changed return types, cleaned the code (kachow)

Fri, Apr 25, 10:17

Thu, Apr 24

hazzarust closed D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.
Thu, Apr 24, 11:24
hazzarust committed rABCaa4e92cbbff4: [chronik] Add block subscription functionality to websocket.rs within… (authored by hazzarust).
[chronik] Add block subscription functionality to websocket.rs within…
Thu, Apr 24, 11:24

Wed, Apr 23

hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Unrelated failure

Wed, Apr 23, 16:00
hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Ammended change

Wed, Apr 23, 14:19
hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

removed lazy_static

Wed, Apr 23, 13:56
hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Added comments

Wed, Apr 23, 13:49
hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

linter hates me

Wed, Apr 23, 13:43
hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Added mut data to the start to avoid repetition, assign the data.endpoint as_mut() so that we can use the values inside data in the same assert_eq statement

Wed, Apr 23, 13:42
hazzarust added inline comments to D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.
Wed, Apr 23, 13:38
hazzarust added inline comments to D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.
Wed, Apr 23, 12:05
hazzarust added inline comments to D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.
Wed, Apr 23, 11:59

Tue, Apr 22

hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Removed macro and created Mutex around data, so that we don't need to constantly lock().await

Tue, Apr 22, 12:16

Sat, Apr 19

hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Finished off the testing for block functionality, improved error handling and removed some questionable comments xd

Sat, Apr 19, 19:06
hazzarust retitled D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client from [chronik] Add websocket.rs integration test to bitcoinsuite-chronik-client to [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.
Sat, Apr 19, 19:02

Tue, Apr 15

hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Changed range (looks like CICD didn't like the old range)

Tue, Apr 15, 11:21
hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Added new branch arms (last time committed wrong change ..)

Tue, Apr 15, 10:46
hazzarust updated the summary of D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.
Tue, Apr 15, 10:41
hazzarust retitled D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client from [chronik] Test subscribe and unsubscribe_to_blocks behaviour in bitcoinsuite-chronik-client to [chronik] Add websocket.rs integration test to bitcoinsuite-chronik-client.
Tue, Apr 15, 10:40
hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

lint

Tue, Apr 15, 10:28
hazzarust updated the summary of D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.
Tue, Apr 15, 10:26
hazzarust planned changes to D17886: [chronik] Add failover_proxy to bitcoinsuite-chronik-client.
Tue, Apr 15, 10:26
hazzarust requested review of D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.
Tue, Apr 15, 10:25

Mon, Apr 14

hazzarust updated the diff for D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.

Removed serial and deserial, removed useless lifetimes, changed from_le_bytes to from_be_hex and thus handled array -> str conversion

Mon, Apr 14, 09:26

Sun, Apr 13

hazzarust planned changes to D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.

Please don't review

Sun, Apr 13, 14:15
hazzarust requested review of D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.
Sun, Apr 13, 14:03

Wed, Apr 9

hazzarust updated the diff for D17886: [chronik] Add failover_proxy to bitcoinsuite-chronik-client.

Made url idiomatic hehe, removed hex import ::* to make more readable, made the other changes suggested

Wed, Apr 9, 11:37

Tue, Apr 8

hazzarust updated the diff for D17886: [chronik] Add failover_proxy to bitcoinsuite-chronik-client.

Removed hex.rs (will be its own seperate diff in future), removed hex boilerplate, removed non diff specific changes

Tue, Apr 8, 11:33

Sat, Apr 5

hazzarust added inline comments to D17886: [chronik] Add failover_proxy to bitcoinsuite-chronik-client.
Sat, Apr 5, 13:32

Thu, Apr 3

hazzarust added a comment to D17886: [chronik] Add failover_proxy to bitcoinsuite-chronik-client.

Please dont review yet,

Thu, Apr 3, 11:39
hazzarust updated the diff for D17886: [chronik] Add failover_proxy to bitcoinsuite-chronik-client.

lint

Thu, Apr 3, 10:00
hazzarust requested review of D17886: [chronik] Add failover_proxy to bitcoinsuite-chronik-client.
Thu, Apr 3, 09:39

Mar 26 2025

hazzarust closed D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.
Mar 26 2025, 11:23
hazzarust committed rABC0c1713d91285: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into… (authored by hazzarust).
[Chronik] Add broadcast_txs_and_validate_rawtxs integration test into…
Mar 26 2025, 11:23

Mar 25 2025

hazzarust updated the diff for D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.

Added comments

Mar 25 2025, 19:04
hazzarust closed D17853: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client.
Mar 25 2025, 19:02
hazzarust committed rABC396a501ae4d5: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client (authored by hazzarust).
[chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client
Mar 25 2025, 19:02
hazzarust added inline comments to D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.
Mar 25 2025, 13:25
hazzarust updated the diff for D17853: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client.

change ordering

Mar 25 2025, 13:11

Mar 24 2025

hazzarust updated the diff for D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.

Made change to how we handle status and ready to reduce indentation

Mar 24 2025, 17:59
hazzarust retitled D17853: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client from [chronik] Ammend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client to [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client.
Mar 24 2025, 17:39
hazzarust updated the diff for D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.

Rebased

Mar 24 2025, 17:39
hazzarust updated the summary of D17853: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client.
Mar 24 2025, 17:36
hazzarust updated the summary of D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.
Mar 24 2025, 17:36
hazzarust requested review of D17853: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client.
Mar 24 2025, 17:36

Mar 22 2025

hazzarust requested review of D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.
Mar 22 2025, 14:25

Mar 15 2025

hazzarust closed D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Mar 15 2025, 17:24
hazzarust committed rABC18cf3e52f32d: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite… (authored by hazzarust).
[chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite…
Mar 15 2025, 17:24

Mar 14 2025

hazzarust updated the diff for D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

lint

Mar 14 2025, 13:06
hazzarust updated the diff for D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

Remove useless comments

Mar 14 2025, 13:05

Mar 13 2025

hazzarust updated the diff for D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

Added comments from TS implementation into this implementation

Mar 13 2025, 19:30
hazzarust added a comment to D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

Still need to add comprehensive comments to explain whats going on within the code, very similar to the TS code - will do this later this evening.

Mar 13 2025, 15:08
hazzarust updated the diff for D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

lint

Mar 13 2025, 15:08
hazzarust updated the diff for D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.

Removed boilerplate and replaced with assert_status_code_eq!()

Mar 13 2025, 15:04
hazzarust closed D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Mar 13 2025, 13:29
hazzarust committed rABCe3e84199d89c: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client (authored by hazzarust).
[chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client
Mar 13 2025, 13:29
hazzarust updated the diff for D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.

Removed test and changed title + summary

Mar 13 2025, 11:30
hazzarust retitled D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client from [chronik] Add extract_status_code function to bitcoinsuite-chronik-client to [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Mar 13 2025, 11:29

Mar 12 2025

hazzarust updated the diff for D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.

lint

Mar 12 2025, 17:08
hazzarust updated the diff for D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.

Removed the impl function and made into macro

Mar 12 2025, 17:07
hazzarust requested review of D17784: [chronik] Add assert_status_code_eq! macro to bitcoinsuite-chronik-client.
Mar 12 2025, 14:13
hazzarust updated the summary of D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Mar 12 2025, 12:07
hazzarust updated the summary of D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Mar 12 2025, 12:07
hazzarust requested review of D17783: [chronik] Add blocktxs_and_tx_and_rawtx.rs integration test to bitcoinsuite-chronik-client.
Mar 12 2025, 12:03

Mar 5 2025

hazzarust closed D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Mar 5 2025, 15:04
hazzarust committed rABC35b43b04dbd2: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite… (authored by hazzarust).
[Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite…
Mar 5 2025, 15:04
hazzarust updated the diff for D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.

Linter

Mar 5 2025, 13:20
hazzarust updated the diff for D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.

fixed error

Mar 5 2025, 12:38
hazzarust added inline comments to D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Mar 5 2025, 11:33

Mar 4 2025

hazzarust updated the diff for D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.

Downcast the Report into ChronikClientError, so that we can now match on status code being returned (thanks Fabien!). Updated variable names from load to get, updated panic messages

Mar 4 2025, 23:25

Feb 27 2025

hazzarust abandoned D17272: [CHRONIK][WEB][MODULES] Updated every out of date dependency in Cargo.toml that does not require code change.
Feb 27 2025, 19:23
hazzarust committed rABC344ee6e4aeb3: [chronik] Add an integration test for the blockchain_info endpoint in… (authored by hazzarust).
[chronik] Add an integration test for the blockchain_info endpoint in…
Feb 27 2025, 13:08
hazzarust closed D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Feb 27 2025, 13:08
hazzarust committed rABC0f4a80e06575: [chronik] Add an integration test for the chronik_info endpoint in bitcoinsuite… (authored by hazzarust).
[chronik] Add an integration test for the chronik_info endpoint in bitcoinsuite…
Feb 27 2025, 13:07
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

rebase

Feb 27 2025, 12:54

Feb 24 2025

hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Updated comment

Feb 24 2025, 22:02
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Updating comment (linter plz dont kill me )

Feb 24 2025, 21:58
hazzarust added inline comments to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Feb 24 2025, 21:52
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Updated !unreachable() comment and removed assert comments

Feb 24 2025, 20:32
hazzarust retitled D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client from [Chronik] Add block_and_blocks integration test into bitcoinsuite-chronik-client to [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Feb 24 2025, 17:52
hazzarust updated the diff for D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.

Merged imports

Feb 24 2025, 17:39
hazzarust updated the test plan for D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Feb 24 2025, 17:12
hazzarust updated the diff for D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.

Updated the assert!() so that it will now anticipate 404 errors, renamed function names to be explicit

Feb 24 2025, 17:12
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Rename blockchain_info_ipc

Feb 24 2025, 12:47

Feb 22 2025

hazzarust updated the diff for D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.

lint

Feb 22 2025, 14:04
hazzarust requested review of D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Feb 22 2025, 14:02
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

lint

Feb 22 2025, 12:39

Feb 21 2025

hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Added unreachable panic, renamed test_blockchain_info to blockchain_info and added comments

Feb 21 2025, 14:11

Feb 20 2025

hazzarust abandoned D17653: [chronik] Add block_and_blocks to bitcoinsuite-chronik-client.
Feb 20 2025, 23:03
hazzarust updated the summary of D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Feb 20 2025, 22:37
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Renamed blockchain_info_new to blockchain_info

Feb 20 2025, 22:36
hazzarust retitled D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client from [chronik] Add blockchain_info to bitcoinsuite-chronik-client to [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Feb 20 2025, 22:36
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

sorry relint

Feb 20 2025, 19:38
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

lint

Feb 20 2025, 19:37
hazzarust added a comment to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

I will make the changes from Pierre's comment in a separate diff to all current integration tests.

Feb 20 2025, 19:36
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Revamped blockchain_info to include the new trait changes.

Feb 20 2025, 19:34
hazzarust accepted D17680: [chronik-client] Fix a bug in the plugins integration test.
Feb 20 2025, 14:43

Feb 8 2025

hazzarust updated the test plan for D17653: [chronik] Add block_and_blocks to bitcoinsuite-chronik-client.
Feb 8 2025, 20:57