User Details
- User Since
- Nov 17 2024, 14:52 (20 w, 10 h)
- Slack Username
- Harry
Sat, Apr 5
Thu, Apr 3
Please dont review yet,
lint
Wed, Mar 26
Tue, Mar 25
Added comments
change ordering
Mon, Mar 24
Made change to how we handle status and ready to reduce indentation
Rebased
Sat, Mar 22
Sat, Mar 15
Fri, Mar 14
lint
Remove useless comments
Thu, Mar 13
Added comments from TS implementation into this implementation
Still need to add comprehensive comments to explain whats going on - will do this later this evening.
lint
Removed boilerplate and replaced with assert_status_code_eq!()
Removed test and changed title + summary
Wed, Mar 12
lint
Removed the impl function and made into macro
Mar 5 2025
Linter
fixed error
Mar 4 2025
Downcast the Report into ChronikClientError, so that we can now match on status code being returned (thanks Fabien!). Updated variable names from load to get, updated panic messages
Feb 27 2025
rebase
Feb 24 2025
Updated comment
Updating comment (linter plz dont kill me )
Updated !unreachable() comment and removed assert comments
Merged imports
Updated the assert!() so that it will now anticipate 404 errors, renamed function names to be explicit
Rename blockchain_info_ipc
Feb 22 2025
lint
lint
Feb 21 2025
Added unreachable panic, renamed test_blockchain_info to blockchain_info and added comments
Feb 20 2025
Renamed blockchain_info_new to blockchain_info
sorry relint
lint
I will make the changes from Pierre's comment in a separate diff to all current integration tests.
Revamped blockchain_info to include the new trait changes.
Feb 8 2025
lint
Feb 4 2025
Jan 27 2025
Jan 25 2025
Jan 24 2025
Asserted at the end of test to make sure we return an error. Killing child process won't return an error, so we get the returned error from assert
Removed timeout
Added error handling
Jan 21 2025
New line added + updated server to make explicit
Removed assert_eq
Jan 20 2025
Removed useless comment
Deleted second test, made socket error handling verbose
Made changes suggested