User Details
- User Since
- Nov 17 2024, 14:52 (22 w, 6 d)
- Slack Username
- Harry
Fri, Apr 25
Roasted by linter, updating
Made changes
Added address.rs to chronik/bitcoinsuite-core, added documentation, changed return types, cleaned the code (kachow)
Thu, Apr 24
Wed, Apr 23
Unrelated failure
Ammended change
removed lazy_static
Added comments
linter hates me
Added mut data to the start to avoid repetition, assign the data.endpoint as_mut() so that we can use the values inside data in the same assert_eq statement
Tue, Apr 22
Removed macro and created Mutex around data, so that we don't need to constantly lock().await
Sat, Apr 19
Finished off the testing for block functionality, improved error handling and removed some questionable comments xd
Tue, Apr 15
Changed range (looks like CICD didn't like the old range)
Added new branch arms (last time committed wrong change ..)
lint
Mon, Apr 14
Removed serial and deserial, removed useless lifetimes, changed from_le_bytes to from_be_hex and thus handled array -> str conversion
Sun, Apr 13
Please don't review
Wed, Apr 9
Made url idiomatic hehe, removed hex import ::* to make more readable, made the other changes suggested
Tue, Apr 8
Removed hex.rs (will be its own seperate diff in future), removed hex boilerplate, removed non diff specific changes
Sat, Apr 5
Thu, Apr 3
Please dont review yet,
lint
Mar 26 2025
Mar 25 2025
Added comments
change ordering
Mar 24 2025
Made change to how we handle status and ready to reduce indentation
Rebased
Mar 22 2025
Mar 15 2025
Mar 14 2025
lint
Remove useless comments
Mar 13 2025
Added comments from TS implementation into this implementation
Still need to add comprehensive comments to explain whats going on within the code, very similar to the TS code - will do this later this evening.
lint
Removed boilerplate and replaced with assert_status_code_eq!()
Removed test and changed title + summary
Mar 12 2025
lint
Removed the impl function and made into macro
Mar 5 2025
Linter
fixed error
Mar 4 2025
Downcast the Report into ChronikClientError, so that we can now match on status code being returned (thanks Fabien!). Updated variable names from load to get, updated panic messages
Feb 27 2025
rebase
Feb 24 2025
Updated comment
Updating comment (linter plz dont kill me )
Updated !unreachable() comment and removed assert comments
Merged imports
Updated the assert!() so that it will now anticipate 404 errors, renamed function names to be explicit
Rename blockchain_info_ipc
Feb 22 2025
lint
lint
Feb 21 2025
Added unreachable panic, renamed test_blockchain_info to blockchain_info and added comments
Feb 20 2025
Renamed blockchain_info_new to blockchain_info
sorry relint
lint
I will make the changes from Pierre's comment in a separate diff to all current integration tests.
Revamped blockchain_info to include the new trait changes.