[chronik-client] Fix a bug in the plugins integration test
ClosedPublic
Actions

Authored by Fabien on Thu, Feb 20, 13:25.

Details

Reviewers

hazzarust
bytesofman

Group Reviewers

Restricted Project

Commits

rABCea44416f09d0: [chronik-client] Fix a bug in the plugins integration test

Summary

The test expects the transactions to be sorted by txid, which is not always true as some mempool endpoints return the txs sorted by time first seen then txid.
Fix this by setting the node mocktime, which makes all the time first seen equal and sorting by txid correct.

Test Plan

./contrib/teamcity/build-configurations.py chronik-client-integration-tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Thu, Feb 20, 13:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Feb 20, 13:25

Fabien requested review of this revision.Thu, Feb 20, 13:25

Harbormaster completed remote builds in B32429: Diff 52689.Thu, Feb 20, 13:34

hazzarust accepted this revision.Thu, Feb 20, 14:43

This revision is now accepted and ready to land.Thu, Feb 20, 14:43

bytesofman accepted this revision.Thu, Feb 20, 14:52

Closed by commit rABCea44416f09d0: [chronik-client] Fix a bug in the plugins integration test (authored by Fabien). · Explain WhyThu, Feb 20, 19:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCea44416f09d0: [chronik-client] Fix a bug in the plugins integration test.

Fabien mentioned this in D17684: [chronik] Fix the chronik_plugins test.Fri, Feb 21, 14:02

Fabien mentioned this in rABC689acf59eacb: [chronik] Fix the chronik_plugins test.Fri, Feb 21, 14:57

Revision Contents
Changeset List

Path

Size

test/

functional/

setup_scripts/

chronik-client_plugins.py

7 lines

Diff 52690

View Options

test/functional/setup_scripts/chronik-client_plugins.py

[chronik-client] Fix a bug in the plugins integration testClosedPublicActions