HomePhabricator

Merge #16688: log: Add validation interface logging

Description

Merge #16688: log: Add validation interface logging

Summary:
f9abf4ab6d3d3e4d4b7e90723020b5422a141a6f Add logging for CValidationInterface events (Jeffrey Czyz)
6edebacb2191373e76d79a4972d6192300976096 Refactor FormatStateMessage for clarity (Jeffrey Czyz)
72f3227c83810936e7a334304e5fd7c6dab8e91b Format CValidationState properly in all cases (Jeffrey Czyz)
428ac70095253225f64462ee15c595644747f376 Add VALIDATION to BCLog::LogFlags (Jeffrey Czyz)

Pull request description:

Add logging of `CValidationInterface` callbacks using a new `VALIDATIONINTERFACE` log flag (see #12994). A separate flag is desirable as the logging can be noisy and thus may need to be disabled without affecting other logging.

This could help debug issues where there may be race conditions at play, such as #12978.

ACKs for top commit:

jnewbery:
  ACK f9abf4ab6d3d3e4d4b7e90723020b5422a141a6f
hebasto:
  ACK f9abf4ab6d3d3e4d4b7e90723020b5422a141a6f
ariard:
  ACK f9abf4a, only changes since 0cadb12 are replacing log indication `VALIDATIONINTERFACE` by `VALIDATION` and avoiding a forward declaration with a new include
ryanofsky:
  Code review ACK f9abf4ab6d3d3e4d4b7e90723020b5422a141a6f. Just suggested changes since last review (thanks!)

Tree-SHA512: 3e0f6e2c8951cf46fbad3ff440971d95d526df2a52a2e4d6452a82785c63d53accfdabae66b0b30e2fe0b00737f8d5cb717edbad1460b63acb11a72c8f5d4236

Partial backport of PR16688
The changes to FormatStateMessage are completely absent because I did not want to mangle them for the sake
of backporting this change, and that particular change depends on a massive stack that isn't necessary to
take advantage of this patch.

Test Plan: ninja check check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6652

Details

Provenance
Wladimir J. van der Laan <laanwj@protonmail.com>Authored on Jun 19 2020, 20:37
abc-botCommitted on Jun 19 2020, 20:43
abc-botPushed on Jun 19 2020, 20:43
Reviewer
Restricted Project
Differential Revision
D6652: Merge #16688: log: Add validation interface logging
Parents
rABC094184ba4325: Merge #15999: init: Remove dead code in LoadChainTip
Branches
Unknown
Tags
Unknown