Diffusion Bitcoin ABC 1601e2b374db

[e.cash] Better handle price api response
1601e2b374db
Actions

Tags

None

Subscribers

None

Description

[e.cash] Better handle price api response

Summary:
Got a NaN displayed from broken price api.
Adding a check to make sure the price value is a number before setting it

Test Plan: npm run dev

Reviewers: #bitcoin_abc, bytesofman

Reviewed By: #bitcoin_abc, bytesofman

Differential Revision: https://reviews.bitcoinabc.org/D17307

Details

Provenance

johnkuney	Authored on Fri, Dec 6, 16:39
johnkuney	Pushed on Fri, Dec 6, 20:07

Reviewer

Restricted Project

Differential Revision

D17307: [e.cash] Better handle price api response

Parents

rABC41a72fe465f1: [cashtab] Cleanup theme file

Branches

Unknown

Tags

Unknown

Event Timeline

johnkuney committed rABC1601e2b374db: [e.cash] Better handle price api response (authored by johnkuney).Fri, Dec 6, 20:07

johnkuney added an edge: D17307: [e.cash] Better handle price api response.

teamcity mentioned this in T3694: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX MacOS is broken..Sat, Dec 7, 12:12

teamcity mentioned this in T3695: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX Windows is broken..

teamcity mentioned this in T3696: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX Linux is broken..Sat, Dec 7, 12:16

Changes (1)

Path

Size

web/

e.cash/

components/

navbar/

getNavbarData.js

rABC1601e2b374db

web/e.cash/components/navbar/getNavbarData.js

Loading...