HomePhabricator

[avalanche] Remove unnecessary code path in addNodeToQuorum

Description

[avalanche] Remove unnecessary code path in addNodeToQuorum

Summary:
This NO_NODE code path is in fact not helpful for testing since it silently
breaks accounting of successfulVotes. Instead of writing tests to test the
test code, we can just get rid of it. Now the voterecord_tests test what we
expect them to.

Depends on D11500

Test Plan:

ninja check-avalanche

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11501

Details

Provenance
sdulfariAuthored on May 19 2022, 18:21
sdulfariPushed on May 21 2022, 05:32
Reviewer
Restricted Project
Differential Revision
D11501: [avalanche] Remove unnecessary code path in addNodeToQuorum
Parents
rABC767e5c7a8044: [avalanche] Add some tests to check that duplicate votes are not counted
Branches
Unknown
Tags
Unknown