HomePhabricator

Fix wait_for_debug_log acting as a noop

Description

Fix wait_for_debug_log acting as a noop

Summary:
wait_for_debug_log is not called using a with statement so the yield returns
the rest of the function as a generator that is never run.

Test Plan:
Wrap the "Avalanche invalidated block {tip_to_park}" check with:

with node.assert_debug_log([f"Avalanche invalidated block {tip_to_park}"]):

This fails!

ninja && ./test/functional/test_runner.py abc_p2p_avalanche_voting

Apply this patch and see that it now succeeds as expected.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: PiRK, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D13172

Details

Provenance
sdulfariAuthored on Feb 27 2023, 18:24
sdulfariPushed on Feb 27 2023, 20:34
Reviewer
Restricted Project
Differential Revision
D13172: Fix wait_for_debug_log acting as a noop
Parents
rABC16f81e976dfa: [Consensus] Allow only tx versions 1 and 2 by consensus
Branches
Unknown
Tags
Unknown