HomePhabricator

Isolating MAX_COINBASE_SCRIPTSIG_SIZE

Description

Isolating MAX_COINBASE_SCRIPTSIG_SIZE

Summary:
The constant MAX_COINBASE_SCRIPTSIG_SIZE was badly located in
'miner.cpp' and thus moved to 'consensus.h'. Furthermore, the
validation was relying on an inline magic number which is now
replaced by the constant.

Test Plan: Compile and run automated tests.

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Subscribers: deadalnix, teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1603

Details

Provenance
vermorelAuthored on Jul 26 2018, 14:06
vermorelPushed on Jul 31 2018, 20:51
Reviewer
Restricted Owners Package
Differential Revision
D1603: Isolating MAX_COINBASE_SCRIPTSIG_SIZE
Parents
rABC3eba1135b26f: Pass flags down to GetSigOpCount
Branches
Unknown
Tags
Unknown