HomePhabricator

[test] Swap debug log and expected messages error string

Description

[test] Swap debug log and expected messages error string

Summary:
The captured debug log can be arbitrary length so it does not make sense to force developers to scroll through their terminal window to find the most useful part of the error. It is best to present it at the end of test result where it is quicker to find (probably on the screen already).

The impact builds like ninja check-functional is negligible since you need to find the failure associated with a specific test. This diff only really impacts running a single test in a development environment, but the impact can be quite large for test failures encountered repeatedly until they are fixed.

Test Plan: Tweak expected messages in assert_debug_log and wait_for_debug_log calls in any test. Run the test and observe the relevant error message is easier to find.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: PiRK

Differential Revision: https://reviews.bitcoinabc.org/D18007

Details

Provenance
roqqitAuthored on Mon, Apr 28, 18:16
roqqitPushed on Mon, Apr 28, 22:16
Reviewer
Restricted Project
Differential Revision
D18007: [test] Swap debug log and expected messages error string
Parents
rABCca9b14c07a55: [chronik-client] Fix WebSocket retry loop issues during disconnection
Branches
Unknown
Tags
Unknown