HomePhabricator

vout parameter check in createrawtransaction is confused with missing &…

Description

vout parameter check in createrawtransaction is confused with missing & type_error.

Summary:
vout parameter in createrawtransaction could be missing or non-num,
but the code simply check the type of vout and throws missing error, which is
not right for string vout.

Test Plan: make check

Reviewers: #bitcoin_abc, O1 Bitcoin ABC, jasonbcox, schancel

Reviewed By: #bitcoin_abc, O1 Bitcoin ABC, jasonbcox, schancel

Subscribers: schancel, jasonbcox, deadalnix, teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1556

Details

Provenance
andychenAuthored on Jul 11 2018, 02:30
andychenPushed on Jul 16 2018, 23:06
Reviewer
Restricted Project
Differential Revision
D1556: vout parameter check in createrawtransaction is confused with missing & type_error.
Parents
rABCc2c31a87e472: Add a flag to activate OP_CHECKDATASIG
Branches
Unknown
Tags
Unknown