Change Details

Cashtab tx parsing was moved to the screen to better support render testing. When parsing was simpler, this was not an issue. Now that we have more app actions and token actions to parse, this needs to be handled async so we do not lock the screen while these calculations are performed.

Cashtab has a bug in tx parsing that causes the UI to lock while tx history is rendered. It's especially noticeable on wallets with Agora txs in history. ' Tx parsing should be done async. The parsed tx should then be passed to the Tx component for rendering. We have instead been using the Tx component to parse and render txs. This diff refactors Cashtab tx parsing so that all parsing is handled by the `parseTx` function, which is called async on each tx. When the history is ready, it is passed to the Tx component for rendering. The size of the refactor makes this a difficult review. However, now that `parsedTx` is strongly typed, the logic changes can be deduced from the new type definitions. We preserve all of the rendering tests, which are updated for some differences in parsing (for example, we now parse each tokenEntry insteead of just the first).

Cashtab tx parsing was moved to the screen to better support render testing.has a bug in tx parsing that causes the UI to lock while tx history is rendered. It's especially noticeable on wallets with Agora txs in history. ' Tx parsing should be done async. The parsed tx should then be passed to the Tx component for rendering. We have instead been using the Tx component to parse and render txs. This diff refactors Cashtab tx parsing so that all parsing is handled by the `parseTx` function, which is called async on each tx. When the history is ready, it is passed to the Tx component for rendering. The size of the refactor makes this a difficult review. However, now that `parsedTx` is strongly typed, When parsing was simpler,the logic changes can be deduced from the new type definitions. this was not an issue.We preserve all of the rendering tests, Now that we have more app actions and token actions to parsewhich are updated for some differences in parsing (for example, this needs to be handled async so we do not lock the screen while these calculations are performedwe now parse each tokenEntry insteead of just the first).