[Cashtab] Parse tx history async to resolve UI lock issue on homescreen
DraftPublic
Actions

Authored by bytesofman on Thu, Dec 12, 15:03.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Cashtab tx parsing was moved to the screen to better support render testing. When parsing was simpler, this was not an issue. Now that we have more app actions and token actions to parse, this needs to be handled async so we do not lock the screen while these calculations are performed.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

unbork-tx-history

Lint

Lint Errors

Severity	Location	Code	Message
Error	cashtab/src/chronik/__tests__/index.test.js:45	ESLINT	jest/no-focused-tests
Error	cashtab/src/chronik/fixtures/vectors.js:87	ESLINT	etc/no-commented-out-code

Unit

No Test Coverage

Build Status

Buildable 31628
Build 62753: Build Diff	ecash-agora-integration-tests · ecash-lib-integration-tests · token-server-tests · cashtab-tests · chronik-client-tests · ecash-herald-tests · chronik-client-integration-tests
Build 62752: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Dec 12, 15:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Dec 12, 15:03

Harbormaster completed remote builds in B31628: Diff 51554.Thu, Dec 12, 15:03

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3335 packages in 24s

323 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (2 low, 4 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.2.12 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2739: Type '{ xecTxType: XecTxType.Received; satoshisSent: number; stackArray: string[]; recipients: string[]; }' is missing the following properties from type 'ParsedTx': parsedTokenEntries, appActions
  [0m [90m 275 |[39m                 tokenFailedParsings[33m:[39m [][33m,[39m
   [90m 276 |[39m                 tokenStatus[33m:[39m [32m'TOKEN_STATUS_NORMAL'[39m[33m,[39m
  [31m[1m>[22m[39m[90m 277 |[39m                 parsed[33m:[39m {
   [90m     |[39m                 [31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m
   [90m 278 |[39m                     xecTxType[33m:[39m [33mXecTxType[39m[33m.[39m[33mReceived[39m[33m,[39m
   [90m 279 |[39m                     satoshisSent[33m:[39m [35m546[39m[33m,[39m
   [90m 280 |[39m                     stackArray[33m:[39m [[0m


Build cashtab-tests failed with exit code 1