Change Details

CommitTransaction returns a bool to indicate success, but since commit b3a74100b8 it only returns true, even if the transaction was not successfully broadcast. This commit changes CommitTransaction() to return void. All dead code in `if (!CommitTransaction())` branches has been removed. https://github.com/bitcoin/bitcoin/pull/17154/commits/d1734f9a3b138ab046f38ee44a09bc3847bf938a --- Depends on D7112 Partial backport of Core PR17154

CommitTransaction returns a bool to indicate success, but since commit b3a74100b8 it only returns true, even if the transaction was not successfully broadcast. This commit changes CommitTransaction() to return void. All dead code in `if (!CommitTransaction())` branches has been removed. https://github.com/bitcoin/bitcoin/pull/17154/commits/d1734f9a3b138ab046f38ee44a09bc3847bf938a --- Depends on D7112 Partial backport of Core [[https://github.com/bitcoin/bitcoin/pull/17154 | PR17154]]

CommitTransaction returns a bool to indicate success, but since commit b3a74100b8 it only returns true, even if the transaction was not successfully broadcast. This commit changes CommitTransaction() to return void. All dead code in `if (!CommitTransaction())` branches has been removed. https://github.com/bitcoin/bitcoin/pull/17154/commits/d1734f9a3b138ab046f38ee44a09bc3847bf938a --- Depends on D7112 Partial backport of Core [[https://github.com/bitcoin/bitcoin/pull/17154 | PR17154]]