Page MenuHomePhabricator

[backport#17154 2/3][wallet] Remove return value from CommitTransaction()
ClosedPublic

Authored by majcosta on Sat, Aug 1, 15:12.

Details

Summary

CommitTransaction returns a bool to indicate success, but since commit
b3a74100b8 it only returns true, even if the transaction was not
successfully broadcast. This commit changes CommitTransaction() to return
void.

All dead code in if (!CommitTransaction()) branches has been removed.

https://github.com/bitcoin/bitcoin/pull/17154/commits/d1734f9a3b138ab046f38ee44a09bc3847bf938a


Depends on D7112

Partial backport of Core PR17154

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Sat, Aug 1, 15:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Aug 1, 15:12
majcosta requested review of this revision.Sat, Aug 1, 15:12
teamcity edited the summary of this revision. (Show Details)Sat, Aug 1, 15:13

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Mon, Aug 3, 09:21
This revision is now accepted and ready to land.Mon, Aug 3, 09:21