Page MenuHomePhabricator

[backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase
ClosedPublic

Authored by majcosta on Fri, Jul 31, 13:07.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Fri, Jul 31, 13:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jul 31, 13:07
majcosta requested review of this revision.Fri, Jul 31, 13:07
teamcity edited the summary of this revision. (Show Details)Fri, Jul 31, 13:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Mon, Aug 3, 08:31
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/askpassphrasedialog.cpp
127 ↗(On Diff #22674)

Layout

145 ↗(On Diff #22674)

Dito

150 ↗(On Diff #22674)

Dito

152 ↗(On Diff #22674)

Dito

160 ↗(On Diff #22674)

Dito

202 ↗(On Diff #22674)

Is that from the linter ? The layour looks bad now

This revision now requires changes to proceed.Mon, Aug 3, 08:31
majcosta updated this revision to Diff 22703.Mon, Aug 3, 13:28

redid the layout on several lines

Fabien accepted this revision.Mon, Aug 3, 13:30
This revision is now accepted and ready to land.Mon, Aug 3, 13:30