Page MenuHomePhabricator

[backport#17300] LegacyScriptPubKeyMan code cleanups
ClosedPublic

Authored by majcosta on Aug 4 2020, 17:31.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC089fb679555a: [backport#17300] LegacyScriptPubKeyMan code cleanups
Summary
Fix missing strFailReason in CreateTransaction (Russell Yanofsky)
Fix misplaced AssertLockHeld (Russell Yanofsky)
doc: Clarify WalletStorage / Wallet relation (Russell Yanofsky)
Add back mistakenly removed AssertLockHeld (Russell Yanofsky)
Refactor: Add GetLegacyScriptPubKeyMan helper (Russell Yanofsky)

Pull request description:

This PR implements suggested code cleanups from https://github.com/bitcoin/bitcoin/pull/17260 review comments

https://github.com/bitcoin/bitcoin/pull/17300/files

Depends on D7119

Backport of Core PR17300

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta requested review of this revision.Aug 4 2020, 17:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Aug 4 2020, 21:22