Page MenuHomePhabricator

[backport#16798] Refactor rawtransaction_util's SignTransaction to separate prevtx parsing

Authored by majcosta on Aug 3 2020, 18:36.



Refactor rawtransaction_util's SignTransaction to have previous tx parsing be separate (Andrew Chow)

Pull request description:

Currently the `SignTransaction` function has to handle both the actual signing and parsing of previous transaction data. This PR splits it so that `SignTransaction` only handles the signing itself and adds a `ParsePrevouts` function which handles parsing the prevtx information.

This allows for `SignTransaction` to just take any `SigningProvider`.

Split from #16341

Backport of Core PR16798

Depends on D7114

Test Plan
ninja check check-functional

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

majcosta requested review of this revision.Aug 3 2020, 18:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Aug 4 2020, 22:36