Page MenuHomePhabricator
Differential D7118

[backport#16798] Refactor rawtransaction_util's SignTransaction to separate prevtx parsing
ClosedPublic
Actions

Authored by majcosta on Aug 3 2020, 18:36.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCf2d57b2aa768: [backport#16798] Refactor rawtransaction_util's SignTransaction to separate…
Summary

Refactor rawtransaction_util's SignTransaction to have previous tx parsing be separate (Andrew Chow)

Pull request description:

Currently the `SignTransaction` function has to handle both the actual signing and parsing of previous transaction data. This PR splits it so that `SignTransaction` only handles the signing itself and adds a `ParsePrevouts` function which handles parsing the prevtx information.

This allows for `SignTransaction` to just take any `SigningProvider`.

Split from #16341

Backport of Core PR16798

Depends on D7114

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Aug 3 2020, 18:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 3 2020, 18:36
majcosta requested review of this revision.Aug 3 2020, 18:36
teamcity edited the summary of this revision. (Show Details)Aug 3 2020, 18:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6998: [backport#17260 1/3] Move wallet enums to walletutil.h.Aug 3 2020, 18:48
Harbormaster completed remote builds in B12289: Diff 22716.Aug 3 2020, 18:49
deadalnix accepted this revision.Aug 4 2020, 22:36
This revision is now accepted and ready to land.Aug 4 2020, 22:36
Closed by commit rABCf2d57b2aa768: [backport#16798] Refactor rawtransaction_util's SignTransaction to separate… (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyAug 5 2020, 05:11
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCf2d57b2aa768: [backport#16798] Refactor rawtransaction_util's SignTransaction to separate….

Revision Contents
Changeset List

PathSize
src/
rpc/
6 lines
23 lines
16 lines
wallet/
6 lines

Diff 22753

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/rawtransaction_util.h

Loading...
View Options

src/rpc/rawtransaction_util.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...