HomePhabricator

[backport#16798] Refactor rawtransaction_util's SignTransaction to separate…

Description

[backport#16798] Refactor rawtransaction_util's SignTransaction to separate prevtx parsing

Summary:
Refactor rawtransaction_util's SignTransaction to have previous tx parsing be separate (Andrew Chow)

Pull request description:

Currently the `SignTransaction` function has to handle both the actual signing and parsing of previous transaction data. This PR splits it so that `SignTransaction` only handles the signing itself and adds a `ParsePrevouts` function which handles parsing the prevtx information.

This allows for `SignTransaction` to just take any `SigningProvider`.

Split from #16341

Backport of Core PR16798

Depends on D7114

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7118

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Sep 7 2019, 00:21
majcostaCommitted on Aug 5 2020, 05:11
majcostaPushed on Aug 5 2020, 05:11
Reviewer
Restricted Project
Differential Revision
D7118: [backport#16798] Refactor rawtransaction_util's SignTransaction to separate prevtx parsing
Parents
rABCa87b1b6c042e: [backport#17154 3/3][wallet] Remove `state` argument from CWallet…
Branches
Unknown
Tags
Unknown