Page MenuHomePhabricator

[backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction
ClosedPublic

Authored by majcosta on Sat, Aug 1, 15:15.

Details

Summary

The state return argument has not been set since commit 611291c198.
Remove it (and the one place that it's used in a calling function).

https://github.com/bitcoin/bitcoin/pull/17154/commits/9e95931865186d7a9a6dc54b64bd96507e9fea4b


Depends on D7113

Concludes backport of Core PR17154

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Sat, Aug 1, 15:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Aug 1, 15:15
majcosta requested review of this revision.Sat, Aug 1, 15:15
teamcity edited the summary of this revision. (Show Details)Sat, Aug 1, 15:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien added a subscriber: Fabien.Mon, Aug 3, 09:30
Fabien added inline comments.
src/interfaces/wallet.cpp
9 ↗(On Diff #22696)

This is removed in the PR, what is it still used for ?

src/wallet/rpcwallet.cpp
10 ↗(On Diff #22696)

Same question

majcosta added inline comments.Mon, Aug 3, 14:04
src/interfaces/wallet.cpp
9 ↗(On Diff #22696)

ContextualCheckTransaction still uses it

deadalnix added inline comments.
src/interfaces/wallet.cpp
9 ↗(On Diff #22696)

It is defined in consensus/tx_verify.h

majcosta added inline comments.Mon, Aug 3, 14:51
src/interfaces/wallet.cpp
71 ↗(On Diff #22696)

I mean, TxValidationState is required for calls to ContextualCheckTransaction here

src/wallet/rpcwallet.cpp
692 ↗(On Diff #22696)

here

766 ↗(On Diff #22696)

here

1200 ↗(On Diff #22696)

and here

deadalnix accepted this revision.Tue, Aug 4, 22:49
This revision is now accepted and ready to land.Tue, Aug 4, 22:49