Page MenuHomePhabricator

[backport#16786] test: add unit test for wallet watch-only methods involving PubKeys
ClosedPublic

Authored by majcosta on Thu, Jul 23, 00:07.

Details

Summary

a57a1d42d52fe51e5b413a1fd3a5ef2b7a2120e3 test: add unit test for wallet watch-only methods involving PubKeys (Sebastian Falbesoner)

Pull request description:

The motivation for this addition was to unit test the function `wallet.cpp:ExtractPubKey()` (see recent change in commit 798a589aff64b83a0844688a661f4bd987c3340c) which is however static and only indirectly available via the public methods `AddWatchOnly()`, `LoadWatchOnly()` and `RemoveWatchOnly()`. Since the first of those methods also stores the addresses to the disk, the second, simpler one was chosen which only operates in memory.

https://github.com/bitcoin/bitcoin/pull/16786/commits/a57a1d42d52fe51e5b413a1fd3a5ef2b7a2120e3


Backport of Core PR16786

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Thu, Jul 23, 00:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jul 23, 00:07
majcosta requested review of this revision.Thu, Jul 23, 00:07
majcosta planned changes to this revision.Thu, Jul 23, 00:12

wrong comments

Fabien accepted this revision.Thu, Jul 23, 07:56
This revision is now accepted and ready to land.Thu, Jul 23, 07:56
teamcity edited the summary of this revision. (Show Details)Mon, Jul 27, 21:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.