HomePhabricator

[backport#16786] test: add unit test for wallet watch-only methods involving…

Description

[backport#16786] test: add unit test for wallet watch-only methods involving PubKeys

Summary:
a57a1d42d52fe51e5b413a1fd3a5ef2b7a2120e3 test: add unit test for wallet watch-only methods involving PubKeys (Sebastian Falbesoner)

Pull request description:

The motivation for this addition was to unit test the function `wallet.cpp:ExtractPubKey()` (see recent change in commit 798a589aff64b83a0844688a661f4bd987c3340c) which is however static and only indirectly available via the public methods `AddWatchOnly()`, `LoadWatchOnly()` and `RemoveWatchOnly()`. Since the first of those methods also stores the addresses to the disk, the second, simpler one was chosen which only operates in memory.

https://github.com/bitcoin/bitcoin/pull/16786/commits/a57a1d42d52fe51e5b413a1fd3a5ef2b7a2120e3


Backport of Core PR16786

Test Plan:

ninja check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7007

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Oct 10 2019, 16:09
majcostaCommitted on Jul 23 2020, 14:46
majcostaPushed on Jul 23 2020, 14:46
Reviewer
Restricted Project
Differential Revision
D7007: [backport#16786] test: add unit test for wallet watch-only methods involving PubKeys
Parents
rABCbc288e874539: Remove BIP9 miner fund.
Branches
Unknown
Tags
Unknown