Page MenuHomePhabricator
Differential D7000

[backport#16361] Remove redundant pre-TopUpKeypool check
ClosedPublic
Actions

Authored by majcosta on Jul 21 2020, 23:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5b0939ce69ed: [backport#16361] Remove redundant pre-TopUpKeypool check
Summary

96b6dd468a4cb6077d1a2267d620d99d39aac7d0 Remove redundant pre-TopUpKeypool checks (Gregory Sanders)

Pull request description:

TopUpKeypool already has a quick check for `IsLocked()`

https://github.com/bitcoin/bitcoin/pull/16361/commits/96b6dd468a4cb6077d1a2267d620d99d39aac7d0

Backport of Core PR16361

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 21 2020, 23:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2020, 23:29
majcosta requested review of this revision.Jul 21 2020, 23:29
majcosta added a child revision: D6998: [backport#17260 1/3] Move wallet enums to walletutil.h.Jul 21 2020, 23:32
Harbormaster completed remote builds in B12099: Diff 22418.Jul 21 2020, 23:40
Fabien accepted this revision.Jul 22 2020, 06:51
This revision is now accepted and ready to land.Jul 22 2020, 06:51
Closed by commit rABC5b0939ce69ed: [backport#16361] Remove redundant pre-TopUpKeypool check (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJul 22 2020, 18:39
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5b0939ce69ed: [backport#16361] Remove redundant pre-TopUpKeypool check.
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 21:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Revision Contents
Changeset List

PathSize
src/
wallet/
14 lines

Diff 22428

View Options

src/wallet/wallet.cpp

Loading...