Page MenuHomePhabricator

[backport#16394] Allow createwallet to take empty passwords to make unencrypted wallets
ClosedPublic

Authored by majcosta on Fri, Jul 31, 15:31.

Details

Summary

Allow createwallet to take empty passwords to make unencrypted wallets (Andrew Chow)

Pull request description:

Allow createwallet to take the empty string as a password and interpret that as leaving the wallet unencrypted. Also warn when that happens.

This fixes a bug where it was not possible to use the `avoid_reuse` option for new unencrypted wallets without using named arguments.Thus this allows more `createwallet` options to be added that can be set on unencrypted wallets when using positional arguments.

https://github.com/bitcoin/bitcoin/pull/16394/commits/c5d37873677551caac34752214dd491f5278c8d5


Backport of Core PR16394

Test Plan
ninja check
./test_runner.py wallet_createwallet

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Fri, Jul 31, 15:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jul 31, 15:31
majcosta requested review of this revision.Fri, Jul 31, 15:31
teamcity edited the summary of this revision. (Show Details)Fri, Jul 31, 15:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox accepted this revision.Fri, Jul 31, 20:20
This revision is now accepted and ready to land.Fri, Jul 31, 20:20