Page MenuHomePhabricator

[backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file
ClosedPublic

Authored by majcosta on Wed, Jul 22, 19:23.

Details

Summary

Start moving wallet and ismine code to scriptpubkeyman.h, scriptpubkeyman.cpp

The easiest way to review this commit is to run:

git log -p -n1 --color-moved=dimmed_zebra

And check that everything is a move (other than includes and copyrights comments).

This commit is move-only and doesn't change code or affect behavior.

https://github.com/bitcoin/bitcoin/pull/17260/commits/6702048f91089d7a565e5ca5f7c8dcd2ca405a85


Depends on D6998

Partial backport of Core PR17260

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Wed, Jul 22, 19:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jul 22, 19:23
majcosta requested review of this revision.Wed, Jul 22, 19:23
deadalnix requested changes to this revision.Wed, Jul 22, 23:11
deadalnix added a subscriber: deadalnix.

Please point to the actual commit.

This revision now requires changes to proceed.Wed, Jul 22, 23:11
majcosta planned changes to this revision.Thu, Jul 23, 00:17
majcosta edited the summary of this revision. (Show Details)

there are a few dependencies that need to be done before I can put this up for review

teamcity edited the summary of this revision. (Show Details)Mon, Jul 27, 22:02

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta updated this revision to Diff 22714.Mon, Aug 3, 17:27

rebase on top of all the finished deps

majcosta edited the summary of this revision. (Show Details)Mon, Aug 3, 18:49
deadalnix accepted this revision.Tue, Aug 4, 22:48
deadalnix added inline comments.
src/script/signingprovider.h
85 ↗(On Diff #22718)

That definitively looks like the most brilliant design decision ever...

This revision is now accepted and ready to land.Tue, Aug 4, 22:48