Page MenuHomePhabricator

[backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file

Authored by majcosta on Jul 22 2020, 19:23.



Start moving wallet and ismine code to scriptpubkeyman.h, scriptpubkeyman.cpp

The easiest way to review this commit is to run:

git log -p -n1 --color-moved=dimmed_zebra

And check that everything is a move (other than includes and copyrights comments).

This commit is move-only and doesn't change code or affect behavior.

Depends on D6998

Partial backport of Core PR17260

Test Plan
ninja check check-functional

Event Timeline

deadalnix requested changes to this revision.Jul 22 2020, 23:11
deadalnix added a subscriber: deadalnix.

Please point to the actual commit.

This revision now requires changes to proceed.Jul 22 2020, 23:11
majcosta edited the summary of this revision. (Show Details)

there are a few dependencies that need to be done before I can put this up for review

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

rebase on top of all the finished deps

deadalnix added inline comments.

That definitively looks like the most brilliant design decision ever...

This revision is now accepted and ready to land.Aug 4 2020, 22:48