Page MenuHomePhabricator
Differential D7006

[backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file
ClosedPublic
Actions

Authored by majcosta on Jul 22 2020, 19:23.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC4c4b9a652121: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman…
Summary

Start moving wallet and ismine code to scriptpubkeyman.h, scriptpubkeyman.cpp

The easiest way to review this commit is to run:

git log -p -n1 --color-moved=dimmed_zebra

And check that everything is a move (other than includes and copyrights comments).

This commit is move-only and doesn't change code or affect behavior.

https://github.com/bitcoin/bitcoin/pull/17260/commits/6702048f91089d7a565e5ca5f7c8dcd2ca405a85

Depends on D6998

Partial backport of Core PR17260

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 22 2020, 19:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 22 2020, 19:23
majcosta requested review of this revision.Jul 22 2020, 19:23
Harbormaster completed remote builds in B12107: Diff 22429.Jul 22 2020, 19:49
deadalnix requested changes to this revision.Jul 22 2020, 23:11
deadalnix added a subscriber: deadalnix.

Please point to the actual commit.

This revision now requires changes to proceed.Jul 22 2020, 23:11
majcosta planned changes to this revision.Jul 23 2020, 00:17
majcosta edited the summary of this revision. (Show Details)

there are a few dependencies that need to be done before I can put this up for review

majcosta edited the summary of this revision. (Show Details)Jul 23 2020, 00:20
majcosta added a parent revision: D7007: [backport#16786] test: add unit test for wallet watch-only methods involving PubKeys.
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:02

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta updated this revision to Diff 22714.Aug 3 2020, 17:27

rebase on top of all the finished deps

Harbormaster completed remote builds in B12287: Diff 22714.Aug 3 2020, 17:42
majcosta updated this revision to Diff 22718.Aug 3 2020, 18:46

rebase

majcosta edited the summary of this revision. (Show Details)Aug 3 2020, 18:49
Harbormaster completed remote builds in B12291: Diff 22718.Aug 3 2020, 19:02
majcosta added a child revision: D7119: [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes.Aug 3 2020, 21:13
deadalnix accepted this revision.Aug 4 2020, 22:48
deadalnix added inline comments.
src/script/signingprovider.h
85 ↗(On Diff #22718)

That definitively looks like the most brilliant design decision ever...

This revision is now accepted and ready to land.Aug 4 2020, 22:48
Closed by commit rABC4c4b9a652121: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 6 2020, 19:55
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC4c4b9a652121: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman….

Revision Contents
Changeset List

PathSize
src/
3 lines
script/
4 lines
wallet/
2 lines
1 line
122 lines
1259 lines
102 lines
1135 lines
1 line

Diff 22778

View Options

src/Makefile.am

Loading...
View Options

src/script/signingprovider.h

Loading...
View Options

src/wallet/CMakeLists.txt

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/ismine.cpp

Loading...
View Options

src/wallet/scriptpubkeyman.h

Loading...
View Options

src/wallet/scriptpubkeyman.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...