Page MenuHomePhabricator
Differential D7102

[backport#15450 1/5] gui: Refactor OpenWalletActivity
ClosedPublic
Actions

Authored by majcosta on Jul 31 2020, 12:49.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe677cd743796: [backport#15450 1/5] gui: Refactor OpenWalletActivity
Summary

https://github.com/bitcoin/bitcoin/pull/15450/commits/bc6d8a3662f0fb992073e5e80269a90a722d76e0

Partial backport of Core PR15450

depends on D7108

Test Plan
ninja check

Open bitcoin-qt open and close wallets to make sure it works as before

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 31 2020, 12:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2020, 12:49
majcosta requested review of this revision.Jul 31 2020, 12:49
teamcity edited the summary of this revision. (Show Details)Jul 31 2020, 12:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12259: Diff 22664.Jul 31 2020, 13:00
majcosta added a child revision: D7103: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase.Jul 31 2020, 13:07
majcosta updated this revision to Diff 22673.Jul 31 2020, 15:33

rebase on D7108

majcosta edited the summary of this revision. (Show Details)Jul 31 2020, 15:34
majcosta added a parent revision: D7108: [backport#16394] Allow createwallet to take empty passwords to make unencrypted wallets.
Harbormaster completed remote builds in B12266: Diff 22673.Jul 31 2020, 15:58
deadalnix added a subscriber: deadalnix.Aug 1 2020, 08:52
deadalnix added inline comments.
src/qt/bitcoingui.cpp
465 ↗(On Diff #22673)

why do you need this->config rather than just config?

majcosta added inline comments.Aug 1 2020, 13:50
src/qt/bitcoingui.cpp
465 ↗(On Diff #22673)

Just to be clear that it's the config member of BitcoinGUI object. It doesn't follow the m_* convention sadly.

deadalnix accepted this revision.Aug 3 2020, 14:10
deadalnix added inline comments.
src/qt/bitcoingui.cpp
465 ↗(On Diff #22673)

Our codebase prevent shadowing anyways, so it is not necessary.

This revision is now accepted and ready to land.Aug 3 2020, 14:10
Closed by commit rABCe677cd743796: [backport#15450 1/5] gui: Refactor OpenWalletActivity (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyAug 3 2020, 15:04
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCe677cd743796: [backport#15450 1/5] gui: Refactor OpenWalletActivity.

Revision Contents
Changeset List

PathSize
src/
qt/
34 lines
56 lines
96 lines

Diff 22706

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/walletcontroller.h

Loading...
View Options

src/qt/walletcontroller.cpp

Loading...