Page MenuHomePhabricator

[backport#15450 1/5] gui: Refactor OpenWalletActivity
ClosedPublic

Authored by majcosta on Jul 31 2020, 12:49.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe677cd743796: [backport#15450 1/5] gui: Refactor OpenWalletActivity
Summary
Test Plan
ninja check

Open bitcoin-qt open and close wallets to make sure it works as before

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added inline comments.
src/qt/bitcoingui.cpp
465 ↗(On Diff #22673)

why do you need this->config rather than just config?

src/qt/bitcoingui.cpp
465 ↗(On Diff #22673)

Just to be clear that it's the config member of BitcoinGUI object. It doesn't follow the m_* convention sadly.

deadalnix added inline comments.
src/qt/bitcoingui.cpp
465 ↗(On Diff #22673)

Our codebase prevent shadowing anyways, so it is not necessary.

This revision is now accepted and ready to land.Aug 3 2020, 14:10