https://github.com/bitcoin/bitcoin/pull/15450/commits/bc6d8a3662f0fb992073e5e80269a90a722d76e0
Partial backport of Core PR15450
depends on D7108
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABCe677cd743796: [backport#15450 1/5] gui: Refactor OpenWalletActivity
ninja check
Open bitcoin-qt open and close wallets to make sure it works as before
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 12259 Build 24729: Build Diff build-clang-10 · build-without-wallet · build-clang-tidy · build-diff Build 24728: arc lint + arc unit
Event Timeline
Comment Actions
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
| src/qt/bitcoingui.cpp | ||
|---|---|---|
| 465 ↗ | (On Diff #22673) | why do you need this->config rather than just config? |
| src/qt/bitcoingui.cpp | ||
|---|---|---|
| 465 ↗ | (On Diff #22673) | Just to be clear that it's the config member of BitcoinGUI object. It doesn't follow the m_* convention sadly. |
| src/qt/bitcoingui.cpp | ||
|---|---|---|
| 465 ↗ | (On Diff #22673) | Our codebase prevent shadowing anyways, so it is not necessary. |