HomePhabricator

[backport#17154 3/3][wallet] Remove `state` argument from CWallet…

Description

[backport#17154 3/3][wallet] Remove state argument from CWallet::CommitTransaction

Summary:
The state return argument has not been set since commit 611291c198.
Remove it (and the one place that it's used in a calling function).

https://github.com/bitcoin/bitcoin/pull/17154/commits/9e95931865186d7a9a6dc54b64bd96507e9fea4b


Depends on D7113

Concludes backport of Core PR17154

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7114

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Oct 18 2019, 13:37
majcostaCommitted on Aug 5 2020, 05:08
majcostaPushed on Aug 5 2020, 05:08
Reviewer
Restricted Project
Differential Revision
D7114: [backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction
Parents
rABC5e00d4893833: [backport#17154 2/3][wallet] Remove return value from CommitTransaction()
Branches
Unknown
Tags
Unknown