Page MenuHomePhabricator
Differential D7128

[backport#17300] LegacyScriptPubKeyMan code cleanups
ClosedPublic
Actions

Authored by majcosta on Aug 4 2020, 17:31.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC089fb679555a: [backport#17300] LegacyScriptPubKeyMan code cleanups
Summary
Fix missing strFailReason in CreateTransaction (Russell Yanofsky)
Fix misplaced AssertLockHeld (Russell Yanofsky)
doc: Clarify WalletStorage / Wallet relation (Russell Yanofsky)
Add back mistakenly removed AssertLockHeld (Russell Yanofsky)
Refactor: Add GetLegacyScriptPubKeyMan helper (Russell Yanofsky)

Pull request description:

This PR implements suggested code cleanups from https://github.com/bitcoin/bitcoin/pull/17260 review comments

https://github.com/bitcoin/bitcoin/pull/17300/files

Depends on D7119

Backport of Core PR17300

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Aug 4 2020, 17:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 4 2020, 17:31
majcosta requested review of this revision.Aug 4 2020, 17:31
teamcity edited the summary of this revision. (Show Details)Aug 4 2020, 17:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12303: Diff 22737.Aug 4 2020, 17:53
jasonbcox accepted this revision.Aug 4 2020, 21:22
This revision is now accepted and ready to land.Aug 4 2020, 21:22
Closed by commit rABC089fb679555a: [backport#17300] LegacyScriptPubKeyMan code cleanups (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyAug 6 2020, 19:57
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC089fb679555a: [backport#17300] LegacyScriptPubKeyMan code cleanups.

Revision Contents
Changeset List

PathSize
src/
wallet/
81 lines
2 lines
2 lines
9 lines

Diff 22737

View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/scriptpubkeyman.h

Loading...
View Options

src/wallet/scriptpubkeyman.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...