Page MenuHomePhabricator
Differential D7103

[backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase
ClosedPublic
Actions

Authored by majcosta on Jul 31 2020, 13:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1d0e49b8553f: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the…
Summary

https://github.com/bitcoin/bitcoin/pull/15450/commits/60adb21c7affb41ec475a62a53fb0a36bea35dfb

Depends on D7102

Partial backport of Core PR15450

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 31 2020, 13:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2020, 13:07
majcosta requested review of this revision.Jul 31 2020, 13:07
teamcity edited the summary of this revision. (Show Details)Jul 31 2020, 13:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7104: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI.Jul 31 2020, 13:08
Harbormaster completed remote builds in B12260: Diff 22665.Jul 31 2020, 13:21
majcosta updated this revision to Diff 22674.Jul 31 2020, 15:34

rebase on D7108

Harbormaster completed remote builds in B12267: Diff 22674.Jul 31 2020, 15:49
Fabien requested changes to this revision.Aug 3 2020, 08:31
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/askpassphrasedialog.cpp
127 ↗(On Diff #22674)

Layout

145 ↗(On Diff #22674)

Dito

150 ↗(On Diff #22674)

Dito

152 ↗(On Diff #22674)

Dito

160 ↗(On Diff #22674)

Dito

202 ↗(On Diff #22674)

Is that from the linter ? The layour looks bad now

This revision now requires changes to proceed.Aug 3 2020, 08:31
majcosta updated this revision to Diff 22703.Aug 3 2020, 13:28

redid the layout on several lines

Fabien accepted this revision.Aug 3 2020, 13:30
This revision is now accepted and ready to land.Aug 3 2020, 13:30
Harbormaster completed remote builds in B12283: Diff 22703.Aug 3 2020, 13:47
Closed by commit rABC1d0e49b8553f: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 3 2020, 15:04
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC1d0e49b8553f: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the….

Revision Contents
Changeset List

PathSize
src/
qt/
6 lines
63 lines

Diff 22707

View Options

src/qt/askpassphrasedialog.h

Loading...
View Options

src/qt/askpassphrasedialog.cpp

Loading...