Change Details

BlockManager::LoadBlockIndex is only called by BlockManager::LoadBlockIndexDB. Thus, it can be made private. m_best_invalid is no longer accessed by BlockManager::LoadBlockIndex. Thus, the unused friend can be removed. This is a backport of core#24917

BlockManager::LoadBlockIndex is only called by BlockManager::LoadBlockIndexDB. Thus, it can be made private. m_best_invalid is no longer accessed by BlockManager::LoadBlockIndex. Thus, the unused friend can be removed. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/24917 | core#24917]]

BlockManager::LoadBlockIndex is only called by BlockManager::LoadBlockIndexDB. Thus, it can be made private. m_best_invalid is no longer accessed by BlockManager::LoadBlockIndex. Thus, the unused friend can be removed. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/24917 | core#24917]]