Page MenuHomePhabricator

Make BlockManager::LoadBlockIndex private
ClosedPublic

Authored by PiRK on Jan 27 2023, 14:44.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC9c56576e4dbd: Make BlockManager::LoadBlockIndex private
Summary

BlockManager::LoadBlockIndex is only called by BlockManager::LoadBlockIndexDB. Thus, it can be made private.
m_best_invalid is no longer accessed by BlockManager::LoadBlockIndex. Thus, the unused friend can be removed.

This is a backport of core#24917

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable