HomePhabricator

Make BlockManager::LoadBlockIndex private

Description

Make BlockManager::LoadBlockIndex private

Summary:
BlockManager::LoadBlockIndex is only called by BlockManager::LoadBlockIndexDB. Thus, it can be made private.
m_best_invalid is no longer accessed by BlockManager::LoadBlockIndex. Thus, the unused friend can be removed.

This is a backport of core#24917

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D13070

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Apr 19 2022, 09:59
PiRKCommitted on Jan 28 2023, 18:48
PiRKPushed on Jan 28 2023, 18:48
Reviewer
Restricted Project
Differential Revision
D13070: Make BlockManager::LoadBlockIndex private
Parents
rABC3cb8cd73ba5d: Remove superfluous landing page
Branches
Unknown
Tags
Unknown