Paths

Table of Contentst

Differential D16084

remove MemPoolRemovalReason::REPLACED
ClosedPublic
Actions

Authored by PiRK on Tue, Apr 30, 09:03.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6da983fb5b60: remove MemPoolRemovalReason::REPLACED

Summary

This RBF related removal reason doesn't actually happen in Bitcoin ABC. It is used only as a dummy value in tests, but in the context of these tests the reason doesn't really matter so we can also use another one.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Tue, Apr 30, 09:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Apr 30, 09:03

PiRK requested review of this revision.Tue, Apr 30, 09:03

Harbormaster completed remote builds in B28813: Diff 47509.Tue, Apr 30, 09:32

PiRK added a child revision: D16085: log: mempool: log removal reason in validation interface.Tue, Apr 30, 09:45

Fabien accepted this revision.Wed, May 1, 06:47

This revision is now accepted and ready to land.Wed, May 1, 06:47

Closed by commit rABC6da983fb5b60: remove MemPoolRemovalReason::REPLACED (authored by PiRK). · Explain WhyThu, May 2, 05:59

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6da983fb5b60: remove MemPoolRemovalReason::REPLACED.

Revision Contents
Changeset List

Path

Size

src/

test/

blockencodings_tests.cpp

2 lines

mempool_tests.cpp

2 lines

txmempool.h

2 lines

Diff 47552

View Options

src/test/blockencodings_tests.cpp

View Options

src/test/mempool_tests.cpp

View Options

remove MemPoolRemovalReason::REPLACEDClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47552

src/test/blockencodings_tests.cpp

src/test/mempool_tests.cpp

src/txmempool.h

remove MemPoolRemovalReason::REPLACED
ClosedPublic
Actions

Revision Contents
Changeset List