HomePhabricator

rearrange ATMP in preparation for SigChecks accounting in mempool

Description

rearrange ATMP in preparation for SigChecks accounting in mempool

Summary:
Once we start using sigchecks in place of sigops, anything relying
on that number can only be run *after* CheckInputs. Notably, the
virtualsize computation and the generation of the CTxMemPoolEntry
(and things using the CTxMemPoolEntry).

This perhaps creates some concerns of DoS vector, however it can
be ameliorated by a future change that runs the standard script
checks with a dummy signature verifier (no signature verification)
and only the consensus script checks need signature verification.
The standard sigcheck count would be put into mempool, however if
the sigchecks counts disagree the transaction should be dropped.

Test Plan: ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Maniphest Tasks: T704

Differential Revision: https://reviews.bitcoinabc.org/D5128

Details

Provenance
Mark Lundeberg <markblundeberg@users.noreply.github.com>Authored on Feb 2 2020, 14:17
FabienPushed on Feb 4 2020, 09:31
Reviewer
Restricted Project
Differential Revision
D5128: rearrange ATMP in preparation for SigChecks accounting in mempool
Parents
rSTAGING5e4cbed27511: Bump version to 0.20.13
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/15992
Tasks
T704: sigChecks implementation